Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls_wrap: use localhost if options.host is empty #1493

Closed
wants to merge 5 commits into from
Closed

tls_wrap: use localhost if options.host is empty #1493

wants to merge 5 commits into from

Commits on Apr 21, 2015

  1. tls_wrap: use localhost if options.host is empty 

    tls.connect(options) with no options.host should accept a certificate
with CN: 'localhost'. Fix Error: Hostname/IP doesn't match
certificate's altnames: "Host: undefined. is not cert's CN: localhost"

'localhost' is not added directly to defaults because that is not
always desired (for example, when using options.socket)

See #1489
    @sitegui
    sitegui committed Apr 21, 2015
    Configuration menu
    Copy the full SHA
    5b225cd View commit details
    Browse the repository at this point in the history

  2. Silly fix for PR1493

    @sitegui
    sitegui committed Apr 21, 2015
    Configuration menu
    Copy the full SHA
    51f90e8 View commit details
    Browse the repository at this point in the history

  3. Wrap at 80 columns

    @sitegui
    sitegui committed Apr 21, 2015
    Configuration menu
    Copy the full SHA
    c3c8d6e View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2015

  1. Style fix

    @sitegui
    sitegui committed Apr 22, 2015
    Configuration menu
    Copy the full SHA
    e5c93eb View commit details
    Browse the repository at this point in the history

  2. Make test quiet

    @sitegui
    sitegui committed Apr 22, 2015
    Configuration menu
    Copy the full SHA
    2d7f52c View commit details
    Browse the repository at this point in the history