Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: improve definition of a collaborator #14981

Closed
wants to merge 2 commits into from
Closed

meta: improve definition of a collaborator #14981

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2360df3
meta: improve definition of a collaborator
jasnell Aug 22, 2017
92d2951
squash: optional overhaul
Trott Aug 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions GOVERNANCE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,21 @@ The [nodejs/node](https://github.com/nodejs/node) GitHub repository is
maintained by Collaborators who are added by the CTC on an ongoing basis.

Individuals identified by the CTC as making significant and valuable
Copy link
Member

@gibfahn gibfahn Aug 22, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So all collaborators are approved by the CTC? Assuming collaborators will now roughly map to @nodejs/members, does this mean everyone who joins the org needs CTC approval? Even if they're joining CommComm for example?

Also is this the current process? If not it seems like something that could use more general members feedback.

The answer could totally be "this is a hard question, let's roll with this and improve it going forward".

EDIT: I think this is what @Trott said:

But the immediate next sentence of the doc says that Collaborators are selected by the CTC. Those folks are not selected by the CTC.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"approval" does not necessarily mean implicit voting.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but identified suggests it's an active thing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the original language and it is definitely lacking. Specific suggestions for improvement are welcome as I'm not sure what would be better

contributions are made Collaborators and given commit access to the project. If
you make a significant contribution and are not considered for commit access,
log an issue or contact a CTC member directly.
contributions across any Node.js repository may be made Collaborators and given
commit access to the project. Activities taken into consideration include (but
are not limited to) the quality of:

* code commits and pull requests
* documentation commits and pull requests
* comments on issues and pull requests
* contributions to the Node.js website
* assistance provided to end users and novice contributors
* participation in Working Groups
* other participation in the wider Node.js community
Copy link
Member

@TimothyGu TimothyGu Aug 23, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's important to bring active members of the Node.js community into the project somehow, but at this point I'm not convinced a contributor without much experience in working on the nodejs/node repo should be given commit access to it (following content is added after edit) for the same reason that I, a Collaborator but not member of any WG, am not given commit access to any WGs' repos.

Copy link
Member

@gibfahn gibfahn Aug 24, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AIUI "commit access to the project" does not mean "commit access to nodejs/node", it means commit access to whichever team you get added to. So if you contribute to core you get made a core collaborator and added to @nodejs/core (assuming we change @nodejs/collaborators to that). If you contribute to the website, then you become a website collaborator and get website access.

To clarify, maybe something like:

-commit access to the project. Activities taken into consideration include (but
+commit access to that repository. Activities taken into consideration include (but

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We seriously need to get better at defining and clarifying the differences :-( ... going to stew on it more


If individuals making valuable contributions do not believe they have been
considered for commit access, they may log an issue or contact a CTC member
directly.

Modifications of the contents of the nodejs/node repository are made on
a collaborative basis. Anybody with a GitHub account may propose a
Expand Down