Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: refactor error handling #14991

Closed
wants to merge 2 commits into from
Closed

http2: refactor error handling #14991

wants to merge 2 commits into from

Commits on Aug 27, 2017

  1. http2: refactor error handling 

    This changes the error handling model of ServerHttp2Stream,
ServerHttp2Request and ServerHttp2Response.
An 'error' emitted on ServerHttp2Stream will not go to
'uncaughtException' anymore, but to the server 'streamError'.
On the stream 'error', ServerHttp2Request will emit 'abort', while
ServerHttp2Response would do nothing

See: nodejs#14963
    @mcollina
    mcollina committed Aug 27, 2017
    Configuration menu
    Copy the full SHA
    054c9c6 View commit details
    Browse the repository at this point in the history

  2. http2: respondWith* to the new error handling 

    Fixes: nodejs#14963
    @mcollina
    mcollina committed Aug 27, 2017
    Configuration menu
    Copy the full SHA
    2857f15 View commit details
    Browse the repository at this point in the history