Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix linter error in html.js #15063

Closed
wants to merge 1 commit into from
Closed

tools: fix linter error in html.js #15063

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Aug 28, 2017

Fixes an error introduced in cacce30

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Aug 28, 2017
@targos
Copy link
Member Author

targos commented Aug 28, 2017

Error before the fix:

./git/nodejs/node/tools/doc/html.js
  199:7  error  'html' is never reassigned. Use 'const' instead  prefer-const

@targos targos mentioned this pull request Aug 28, 2017
Closed
3 tasks
@targos
Copy link
Member Author

targos commented Aug 28, 2017

Linter run: https://ci.nodejs.org/job/node-test-linter/11466/

Trott
Trott approved these changes Aug 28, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No need to wait the full 48 hours on this, IMO.

hiroppy
hiroppy approved these changes Aug 28, 2017
View reviewed changes
Copy link
Member

@hiroppy hiroppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Agree with @Trott.

@targos
Copy link
Member Author

targos commented Aug 28, 2017

Feel free to land it. I won't be able to before tomorrow.

hiroppy pushed a commit to hiroppy/node that referenced this pull request Aug 28, 2017
@targos @hiroppy
tools: fix linter error in html.js
7854562 
PR-URL: nodejs#15063
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@hiroppy
Copy link
Member

hiroppy commented Aug 28, 2017

landed in 7854562

@hiroppy hiroppy closed this Aug 28, 2017
ghost pushed a commit to ayojs/ayo that referenced this pull request Aug 30, 2017
@targos
tools: fix linter error in html.js
86f4630 
PR-URL: nodejs/node#15063
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
ghost pushed a commit to ayojs/ayo that referenced this pull request Aug 30, 2017
@targos
tools: fix linter error in html.js
c83c108 
PR-URL: nodejs/node#15063
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
cjihrig pushed a commit to cjihrig/node that referenced this pull request Aug 31, 2017
@targos @cjihrig
tools: fix linter error in html.js
a1bb9c1 
PR-URL: nodejs#15063
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@targos @MylesBorins
tools: fix linter error in html.js
b293b5a 
PR-URL: #15063
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@targos @MylesBorins
tools: fix linter error in html.js
bc250a1 
PR-URL: #15063
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@targos targos deleted the fix-lint-tools branch September 24, 2017 10:54
chris--young pushed a commit to chris--young/node that referenced this pull request Sep 29, 2017
@targos
tools: fix linter error in html.js
abc4272 
PR-URL: nodejs#15063
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins pushed a commit that referenced this pull request Sep 29, 2017
@targos @MylesBorins
tools: fix linter error in html.js
37dd2ad 
Backport-PR-URL: #15670
PR-URL: #15063
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@MylesBorins MylesBorins mentioned this pull request Sep 29, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiroppy hiroppy hiroppy approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@targos @hiroppy @Trott @cjihrig @MylesBorins @nodejs-github-bot