Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

child_process: ignore undef/proto values of env #15089

Closed
wants to merge 2 commits into from
Closed

child_process: ignore undef/proto values of env #15089

wants to merge 2 commits into from

Commits on Dec 6, 2017

  1. child_process: ignore undef/proto values of env 

    At present, undefined values of env option will be transferred as
a "undefined" string value, and values in prototype will also be
included, which are not usual behaviors.

Since non-string env values & prototype values are undocumented,
this change may be treated as a bugfix or a breaking change.

Tested on Mac, Windows not yet.

Fixes: nodejs#15087
    @Gerhut
    Gerhut committed Dec 6, 2017
    Configuration menu
    Copy the full SHA
    5e37647 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2018

  1. fixup: fix test for Windows

    @targos
    targos committed Jan 15, 2018
    1 Configuration menu
    Copy the full SHA
    e7c8d07 View commit details
    Browse the repository at this point in the history