Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove not relevant todo from node_crypto.cc #15104

Closed
wants to merge 1 commit into from
Closed

src: remove not relevant todo from node_crypto.cc #15104

wants to merge 1 commit into from

Conversation

barnski
Copy link
Contributor

@barnski barnski commented Aug 30, 2017

TODO comment from node_crypto is no longer relevant.
Unification of commented code and string_bytes code would bloat the latter.
Methods for hex encoding produce different output in both files (crypto adds colon and uses uppercase letters.)
Common path between those two is very limited now.

Checklist
  • [x ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x ] commit message follows commit guidelines

@barnski
src: remove not relevant todo from node_crypto.cc
0ac09ae 
TODO comment from node_crypto is no longer relevant.
Unification of commented code and string_bytes code would bloat the latter.
Methods for hex encoding produce different output in both files (crypto adds colon and uses uppercase letters.)
Common path between those two is very limited now.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Aug 30, 2017
@jasnell
Copy link
Member

jasnell commented Aug 30, 2017

ping @indutny ... this was your todo

@BridgeAR
Copy link
Member

Well... there were so many changes since 2014 when that TODO landed that it is indeed unlikely that this is still relevant.

BridgeAR
BridgeAR approved these changes Sep 13, 2017
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this because it is a very old comment and there was no further response from @indutny

@jasnell
Copy link
Member

jasnell commented Sep 15, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10103/

@BridgeAR
Copy link
Member

@barnski congratulations on your first commit to Node.js 🎉

Landed in 4dc920a

@BridgeAR BridgeAR closed this Sep 19, 2017
BridgeAR pushed a commit that referenced this pull request Sep 19, 2017
@barnski @BridgeAR
src: remove outdated todo from node_crypto.cc
4dc920a 
TODO comment from node_crypto is no longer relevant. Unification of
commented code and string_bytes code would bloat the latter. Methods
for hex encoding produce different output in both files (crypto adds
colon and uses uppercase letters.) Common path between those two is
very limited now.

PR-URL: #15104
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Sep 20, 2017
@barnski @jasnell
src: remove outdated todo from node_crypto.cc
8c480f9 
TODO comment from node_crypto is no longer relevant. Unification of
commented code and string_bytes code would bloat the latter. Methods
for hex encoding produce different output in both files (crypto adds
colon and uses uppercase letters.) Common path between those two is
very limited now.

PR-URL: #15104
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell mentioned this pull request Sep 20, 2017
Merged
Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017
@barnski
src: remove outdated todo from node_crypto.cc
0342aeb 
TODO comment from node_crypto is no longer relevant. Unification of
commented code and string_bytes code would bloat the latter. Methods
for hex encoding produce different output in both files (crypto adds
colon and uses uppercase letters.) Common path between those two is
very limited now.

PR-URL: nodejs/node#15104
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 17, 2017
@barnski @MylesBorins
src: remove outdated todo from node_crypto.cc
13b2231 
TODO comment from node_crypto is no longer relevant. Unification of
commented code and string_bytes code would bloat the latter. Methods
for hex encoding produce different output in both files (crypto adds
colon and uses uppercase letters.) Common path between those two is
very limited now.

PR-URL: #15104
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 17, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
@barnski @MylesBorins
src: remove outdated todo from node_crypto.cc
0b5798b 
TODO comment from node_crypto is no longer relevant. Unification of
commented code and string_bytes code would bloat the latter. Methods
for hex encoding produce different output in both files (crypto adds
colon and uses uppercase letters.) Common path between those two is
very limited now.

PR-URL: #15104
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@barnski @jasnell @BridgeAR @MylesBorins @nodejs-github-bot