Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: add syntax check before wrap origin script #1516

Closed
wants to merge 1 commit into from
Closed

module: add syntax check before wrap origin script #1516

wants to merge 1 commit into from

Conversation

JacksonTian
Copy link
Contributor

Add syntax check for origin script code.

fix nodejs/node-v0.x-archive#8183

@brendanashworth brendanashworth added the module Issues and PRs related to the module subsystem. label Apr 24, 2015
@Slayer95
Copy link

This likely removes support for module-level return, which is often seen in the wild.

@vkurchatkin
Copy link
Contributor

-1. a - this is a breaking change (though people using return are asking for trouble). b - I suspect it makes require significantly slower

This was referenced Nov 25, 2020
Open
Merged
@snyk-bot snyk-bot mentioned this pull request Jul 28, 2021
Open
This was referenced Jun 21, 2023
Open
Open
Open
Open
Open
Open
Open
Open
@adamlaska adamlaska mentioned this pull request Jun 23, 2023
Open
@aliscco aliscco mentioned this pull request Jun 24, 2023
Open
This was referenced Jul 6, 2023
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
module Issues and PRs related to the module subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

funny code
4 participants
@JacksonTian @Slayer95 @vkurchatkin @brendanashworth