Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: coverity fixes for ESM C++ #15275

Closed
wants to merge 1 commit into from
Closed

module: coverity fixes for ESM C++ #15275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/module_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ inline const struct read_result read_file(uv_file file) {
}
struct file_check {
bool failed = true;
uv_file file;
uv_file file = -1;
} file_check;
inline const struct file_check check_file(URL search,
bool close = false,
Expand Down Expand Up @@ -461,7 +461,7 @@ URL Resolve(std::string specifier, URL* base, bool read_pkg_json) {
} else {
return resolve_module(specifier, base);
}
return URL("");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you replace this with an UNREACHABLE()?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, would it not even be better to just remove the else instead and have the regular return afterwards?

UNREACHABLE();
}

void ModuleWrap::Resolve(const FunctionCallbackInfo<Value>& args) {
Expand Down