test: remove invalid test #15320
Closed
test: remove invalid test #15320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`test/known_issues/test-stdout-buffer-flush-on-exit.js` is invalid. The behavior seen currently (with the test failing) is in accordance with documentation which indicates that calling `process.exit()` may mean scheduled asynchronous I/O does not happen. The documentation also indicates that `process.stdout` is asynchronous when it is a POSIX pipe.
cjihrig
approved these changes
Sep 10, 2017
gibfahn
approved these changes
Sep 10, 2017
tniessen
approved these changes
Sep 11, 2017
jasnell
approved these changes
Sep 12, 2017
|
Landed in 6cfd773 |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Sep 13, 2017
`test/known_issues/test-stdout-buffer-flush-on-exit.js` is invalid. The behavior seen currently (with the test failing) is in accordance with documentation which indicates that calling `process.exit()` may mean scheduled asynchronous I/O does not happen. The documentation also indicates that `process.stdout` is asynchronous when it is a POSIX pipe. PR-URL: nodejs#15320 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 17, 2017
`test/known_issues/test-stdout-buffer-flush-on-exit.js` is invalid. The behavior seen currently (with the test failing) is in accordance with documentation which indicates that calling `process.exit()` may mean scheduled asynchronous I/O does not happen. The documentation also indicates that `process.stdout` is asynchronous when it is a POSIX pipe. PR-URL: nodejs/node#15320 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Sep 20, 2017
`test/known_issues/test-stdout-buffer-flush-on-exit.js` is invalid. The behavior seen currently (with the test failing) is in accordance with documentation which indicates that calling `process.exit()` may mean scheduled asynchronous I/O does not happen. The documentation also indicates that `process.stdout` is asynchronous when it is a POSIX pipe. PR-URL: #15320 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Qard
pushed a commit
to Qard/ayo
that referenced
this pull request
Sep 21, 2017
`test/known_issues/test-stdout-buffer-flush-on-exit.js` is invalid. The behavior seen currently (with the test failing) is in accordance with documentation which indicates that calling `process.exit()` may mean scheduled asynchronous I/O does not happen. The documentation also indicates that `process.stdout` is asynchronous when it is a POSIX pipe. PR-URL: nodejs/node#15320 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 17, 2017
`test/known_issues/test-stdout-buffer-flush-on-exit.js` is invalid. The behavior seen currently (with the test failing) is in accordance with documentation which indicates that calling `process.exit()` may mean scheduled asynchronous I/O does not happen. The documentation also indicates that `process.stdout` is asynchronous when it is a POSIX pipe. PR-URL: #15320 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Oct 25, 2017
`test/known_issues/test-stdout-buffer-flush-on-exit.js` is invalid. The behavior seen currently (with the test failing) is in accordance with documentation which indicates that calling `process.exit()` may mean scheduled asynchronous I/O does not happen. The documentation also indicates that `process.stdout` is asynchronous when it is a POSIX pipe. PR-URL: #15320 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test/known_issues/test-stdout-buffer-flush-on-exit.jsis invalid. Thebehavior seen currently (with the test failing) is in accordance with
documentation which indicates that calling
process.exit()may meanscheduled asynchronous I/O does not happen. The documentation also
indicates that
process.stdoutis asynchronous when it is a POSIX pipe.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test