Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test-http2-session-timeout #15328

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 11, 2017

Increase server timeout to reduce likelihood of triggering race
conditions.

Fixes: #15326

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test http2

@Trott Trott added http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests. labels Sep 11, 2017
@Trott
Copy link
Member Author

Trott commented Sep 11, 2017

@Trott
Copy link
Member Author

Trott commented Sep 11, 2017

With this change, I am able to reliably run 96 concurrent versions of the test without any failures. Prior to this, the test was reliably failing with 32 concurrent versions or even less. It was also observed failing on CI on FreeBSD.

@Trott
Copy link
Member Author

Trott commented Sep 11, 2017

(Can't run a stress test until #15300 lands.)

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina
Copy link
Member

As a reference, this was introduced in #15188.

I do not see any strategy to test this differently.

cc @apapirovski @nodejs/http2

@apapirovski
Copy link
Member

apapirovski commented Sep 11, 2017

This no longer tests the timeout condition because the test only runs 40 requests 10ms apart, so it ends way before the timeout would trigger.

I have a fix in progress with a slightly different approach. Will open a PR, if you don't mind. I don't think increasing the values is enough because it seems like the reason it's failing on FreeBSD is that the server close takes too long (successful runs on that system take less than 500ms and failing ones take almost 2s).

@mcollina
Copy link
Member

I would prefer #15338

@jasnell
Copy link
Member

jasnell commented Sep 12, 2017

I also prefer #15338

Increase server timeout to reduce likelihood of triggering race
conditions.

Fixes: nodejs#15326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test-http2-session-timeout flaky on FreeBSD
6 participants