Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix Buffer.allocUnsafeSlow is added in 5.12.0 instead of 5.10.0 #15330

Closed
wants to merge 1 commit into from
Closed

docs: fix Buffer.allocUnsafeSlow is added in 5.12.0 instead of 5.10.0 #15330

wants to merge 1 commit into from

Conversation

tuananh
Copy link
Contributor

@tuananh tuananh commented Sep 11, 2017

Updating docs: Buffer.allocUnsafeSlow() is added in v5.12.0 instead of 5.10.0

Fixed: #15279

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

None

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Sep 11, 2017
@vsemozhetbyt vsemozhetbyt mentioned this pull request Sep 13, 2017
Closed
4 tasks
vsemozhetbyt pushed a commit that referenced this pull request Sep 13, 2017
@tuananh @vsemozhetbyt
doc: fix "added in" for Buffer.allocUnsafeSlow()
0dad97c 
PR-URL: #15330
Fixes: #15279
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@vsemozhetbyt
Copy link
Contributor

Basing on this comment in identical PR, landed in 0dad97c

@vsemozhetbyt
Copy link
Contributor

@tuananh Thank you for the contribution!

addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 17, 2017
@tuananh @addaleax
doc: fix "added in" for Buffer.allocUnsafeSlow()
2d2c5d6 
PR-URL: nodejs/node#15330
Fixes: nodejs/node#15279
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jasnell pushed a commit that referenced this pull request Sep 20, 2017
@tuananh @jasnell
doc: fix "added in" for Buffer.allocUnsafeSlow()
b0f5b2a 
PR-URL: #15330
Fixes: #15279
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell jasnell mentioned this pull request Sep 20, 2017
Merged
Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017
@tuananh
doc: fix "added in" for Buffer.allocUnsafeSlow()
e8e1d8f 
PR-URL: nodejs/node#15330
Fixes: nodejs/node#15279
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 17, 2017
@tuananh @MylesBorins
doc: fix "added in" for Buffer.allocUnsafeSlow()
bf13007 
PR-URL: #15330
Fixes: #15279
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 17, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
@tuananh @MylesBorins
doc: fix "added in" for Buffer.allocUnsafeSlow()
0b2d548 
PR-URL: #15330
Fixes: #15279
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tuananh @vsemozhetbyt @jasnell @lpinca @cjihrig @richardlau @MylesBorins @nodejs-github-bot