Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix typo in probe description #15397

Closed
wants to merge 1 commit into from
Closed

src: fix typo in probe description #15397

wants to merge 1 commit into from

Conversation

evanlucas
Copy link
Contributor

This fixes a typo in a probe description added in
dc1996d.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@evanlucas
src: fix typo in probe description
5220993 
This fixes a typo in a probe description added in
dc1996d.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 13, 2017
@evanlucas
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/10066/

@jasnell
Copy link
Member

jasnell commented Sep 14, 2017

This shouldn't need to wait the 48 hours

jasnell pushed a commit that referenced this pull request Sep 14, 2017
@evanlucas @jasnell
src: fix typo in probe description
d195a06 
This fixes a typo in a probe description added in
dc1996d.

PR-URL: #15397
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell
Copy link
Member

jasnell commented Sep 14, 2017

Landed in d195a06

@jasnell jasnell closed this Sep 14, 2017
@evanlucas evanlucas deleted the ustacktypo branch September 15, 2017 18:23
@evanlucas
Copy link
Contributor Author

Thanks for landing James!

addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 17, 2017
@evanlucas @addaleax
src: fix typo in probe description
1c98dbd 
This fixes a typo in a probe description added in
dc1996d.

PR-URL: nodejs/node#15397
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell
Copy link
Member

jasnell commented Sep 20, 2017

Ping @MylesBorins .. this needs to land along with the V8 6.1 bump in v8.x

Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017
@evanlucas
src: fix typo in probe description
9b674f1 
This fixes a typo in a probe description added in
dc1996d.

PR-URL: nodejs/node#15397
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 29, 2017
@evanlucas @MylesBorins
src: fix typo in probe description
f53ca10 
This fixes a typo in a probe description added in
dc1996d.

PR-URL: #15397
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@evanlucas @MylesBorins
src: fix typo in probe description
5b21109 
This fixes a typo in a probe description added in
dc1996d.

PR-URL: #15397
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 3, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@evanlucas @MylesBorins
src: fix typo in probe description
ca02576 
This fixes a typo in a probe description added in
dc1996d.

PR-URL: #15397
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@evanlucas @jasnell @addaleax @lpinca @cjihrig @BridgeAR @MylesBorins @nodejs-github-bot