Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix addon loader regression #154

Merged
merged 1 commit into from
Dec 13, 2014
Merged

src: fix addon loader regression #154

merged 1 commit into from
Dec 13, 2014

Commits on Dec 13, 2014

  1. src: fix addon loader regression 

    Fix a regression that was introduced in commit a38b917 by removing the
bad check.  Also rearrange the addon loading logic to ensure that the
list of pending addons remains in a consistent state when the shared
object fails to load; in particular, when an addon self-registers first,
then hits a dynamic linker error in a later constructor.

Fixes the following asserting when loading a .node shared object:

    node: ../src/node.cc:1944: void node::node_module_register(void*):
    Assertion `(modpending) != (nullptr)' failed.

Fixes strongloop/strongops#233.

PR-URL: nodejs#154
Reviewed-By: Ryan Graham <ryan@strongloop.com>
    @bnoordhuis
    bnoordhuis committed Dec 13, 2014
    Configuration menu
    Copy the full SHA
    a60056d View commit details
    Browse the repository at this point in the history