doc: make mkdtemp example work on Windows #15408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
cjihrig
approved these changes
Sep 14, 2017
doc/api/fs.md
Outdated
| @@ -1536,10 +1536,11 @@ object with an `encoding` property specifying the character encoding to use. | |||
| Example: | |||
|
|
|||
| ```js | |||
| fs.mkdtemp('/tmp/foo-', (err, folder) => { | |||
| const tempFolder = process.platform === 'win32' ? process.env['TEMP'] : '/tmp'; | |||
There was a problem hiding this comment.
Why not use os.tmpDir() here?
There was a problem hiding this comment.
You are right, updated.
vsemozhetbyt
approved these changes
Sep 14, 2017
BridgeAR
approved these changes
Sep 14, 2017
jasnell
approved these changes
Sep 14, 2017
lpinca
reviewed
Sep 14, 2017
| if (err) throw err; | ||
| console.log(folder); | ||
| // Prints: /tmp/foo-itXde2 | ||
| // Prints: /tmp/foo-itXde2 or C:\Users\...\AppData\Local\Temp\foo-itXde2 |
There was a problem hiding this comment.
I think this is also incorrect for macOS.
There was a problem hiding this comment.
This should not be blocking though, right? As a comment it should be fine as is? (I do not have a Mac to test this on my own)
There was a problem hiding this comment.
Can confirm the tmp dir is different on macOS but ofc this comment should not block PR from landing.
lpinca
approved these changes
Sep 14, 2017
|
Landed in 1ebde6e |
Qard
pushed a commit
to Qard/ayo
that referenced
this pull request
Sep 21, 2017
PR-URL: nodejs/node#15408 Fixes: nodejs/node#14960 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Qard
pushed a commit
to Qard/ayo
that referenced
this pull request
Sep 21, 2017
PR-URL: nodejs/node#15408 Fixes: nodejs/node#14960 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
landed this on v6.x, please lmk if it is not relevant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14960
Checklist
Affected core subsystem(s)
doc