Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: fix subsequent end calls to not throw #15414

Closed
wants to merge 1 commit into from
Closed

http2: fix subsequent end calls to not throw #15414

wants to merge 1 commit into from
+7 −5

Commits on Sep 14, 2017

  1. http2: fix subsequent end calls to not throw 

    Calling Http2ServerResponse.end multiple times should never
cause the code to throw an error, subsequent calls should
instead return false. Fix behaviour to match http1.

Fixes: https://github.com/nodejs/node/issues/15385m
    @apapirovski
    apapirovski committed Sep 14, 2017
    Configuration menu
    Copy the full SHA
    8be7991 View commit details
    Browse the repository at this point in the history