Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: emit close event if request aborted #15415

Closed
wants to merge 1 commit into from
Closed

http2: emit close event if request aborted #15415

wants to merge 1 commit into from

Conversation

apapirovski
Copy link
Member

@apapirovski apapirovski commented Sep 14, 2017 •
edited
Loading

Fix Http2ServerRequest and Http2ServerResponse to emit close event if the request is aborted before response.end() can be called. The test is adapted from an equivalent test in http1 so this behaviour matches http1. This fully fixes #15385

Wasn't sure if we needed to check more than this.writable within onStreamAbortedResponse — welcome any other input on that (and the rest). Thanks!

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

http2, test

@apapirovski
http2: emit close event if request aborted
777590e 
Fix Http2ServerRequest and Http2ServerResponse to emit close event
if the request is aborted before response.end can be called.

Fixes: nodejs#15385
@nodejs-github-bot nodejs-github-bot added the http2 Issues or PRs related to the http2 subsystem. label Sep 14, 2017
mcollina
mcollina approved these changes Sep 15, 2017
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10117/

@akc42 akc42 mentioned this pull request Sep 18, 2017
Closed
@mcollina
Copy link
Member

Landed as 8fa5fcc.

@mcollina mcollina closed this Sep 18, 2017
mcollina pushed a commit that referenced this pull request Sep 18, 2017
@apapirovski @mcollina
http2: emit close event if request aborted
8fa5fcc 
Fix Http2ServerRequest and Http2ServerResponse to emit close event
if the request is aborted before response.end can be called.

Fixes: #15385
PR-URL: #15415
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@apapirovski apapirovski deleted the patch-http2-compat-close-event branch September 19, 2017 13:59
jasnell pushed a commit that referenced this pull request Sep 20, 2017
@apapirovski @jasnell
http2: emit close event if request aborted
2ea2725 
Fix Http2ServerRequest and Http2ServerResponse to emit close event
if the request is aborted before response.end can be called.

Fixes: #15385
PR-URL: #15415
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell mentioned this pull request Sep 20, 2017
Merged
Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017
@apapirovski
http2: emit close event if request aborted
2d4a1e4 
Fix Http2ServerRequest and Http2ServerResponse to emit close event
if the request is aborted before response.end can be called.

Fixes: nodejs/node#15385
PR-URL: nodejs/node#15415
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017
@apapirovski
http2: emit close event if request aborted
4791bb4 
Fix Http2ServerRequest and Http2ServerResponse to emit close event
if the request is aborted before response.end can be called.

Fixes: nodejs/node#15385
PR-URL: nodejs/node#15415
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

http2: client browser refresh crashing the server.
5 participants
@apapirovski @mcollina @jasnell @MylesBorins @nodejs-github-bot