doc: fix types and description for dns.resolveTxt #15472
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tniessen
added
dns
nodejs-github-bot
added
dns
lpinca
approved these changes
Sep 19, 2017
cjihrig
approved these changes
Sep 19, 2017
jasnell
approved these changes
Sep 19, 2017
silverwind
approved these changes
Sep 19, 2017
tniessen
added a commit
that referenced
this pull request
Sep 22, 2017
PR-URL: #15472 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in 3888a57. |
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 23, 2017
PR-URL: nodejs/node#15472 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Sep 25, 2017
PR-URL: #15472 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
is this relevant for v6.x? |
|
Yes, it should be backported. |
|
It will need to be manually backported if we want to land it 🙃 |
tniessen
added a commit
to tniessen/node
that referenced
this pull request
Oct 20, 2017
PR-URL: nodejs#15472 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TXT records are a collection of strings, so a collection of TXT records should be represented as a two-dimensional array of strings in the docs.
Checklist
Affected core subsystem(s)
doc