Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: adds support for --pending-deprecation in NODE_OPTIONS. #15494

Closed
wants to merge 1 commit into from
Closed

cli: adds support for --pending-deprecation in NODE_OPTIONS. #15494

wants to merge 1 commit into from

Conversation

tomc974
Copy link
Contributor

@tomc974 tomc974 commented Sep 20, 2017

Fixes: #15484

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

cli

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 20, 2017
@mscdex mscdex added the cli Issues and PRs related to the Node.js command line interface. label Sep 20, 2017
@BridgeAR
Copy link
Member

CI https://ci.nodejs.org/job/node-test-pull-request/10234/

@BridgeAR
Copy link
Member

Landed in 3d7f7b2

@BridgeAR BridgeAR closed this Sep 24, 2017
BridgeAR pushed a commit that referenced this pull request Sep 24, 2017
@tomc974 @BridgeAR
src: add --pending-deprecation to NODE_OPTIONS
3d7f7b2 
PR-URL: #15494
Fixes: #15484
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
Copy link
Member

@tomc974 congratulations to your first commit to Node.js! 🎉

jasnell pushed a commit that referenced this pull request Sep 25, 2017
@tomc974 @jasnell
src: add --pending-deprecation to NODE_OPTIONS
4f88c19 
PR-URL: #15494
Fixes: #15484
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 30, 2017
@tomc974 @addaleax
src: add --pending-deprecation to NODE_OPTIONS
11e93cc 
PR-URL: nodejs/node#15494
Fixes: nodejs/node#15484
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins
Copy link
Contributor

Should this be backported to 6.x? We now have support for NODE_OPTIONS and the PR lands cleanly

As an aside, should this have been landed as Semver-Minor?

@MylesBorins MylesBorins mentioned this pull request Oct 17, 2017
Closed
2 tasks
MylesBorins pushed a commit that referenced this pull request Nov 14, 2017
@tomc974 @MylesBorins
src: add --pending-deprecation to NODE_OPTIONS
9f80868 
PR-URL: #15494
Fixes: #15484
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins
Copy link
Contributor

I'm going to land this and stick to original semveryness
@nodejs/lts lmk if you dissagree

@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@tomc974 @MylesBorins
src: add --pending-deprecation to NODE_OPTIONS
4b65a0f 
PR-URL: #15494
Fixes: #15484
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@tomc974 @MylesBorins
src: add --pending-deprecation to NODE_OPTIONS
75b1e30 
PR-URL: #15494
Fixes: #15484
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@tomc974 tomc974 deleted the fix-for-15484 branch November 29, 2017 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. cli Issues and PRs related to the Node.js command line interface.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tomc974 @BridgeAR @MylesBorins @jasnell @cjihrig @mscdex @nodejs-github-bot