v6.11.4 proposal

.eslintrc.yaml

@@ -13,67 +13,67 @@ parserOptions:
 rules:
   # Possible Errors
   # http://eslint.org/docs/rules/#possible-errors
-  comma-dangle: [2, only-multiline]
-  no-control-regex: 2
-  no-debugger: 2
-  no-dupe-args: 2
-  no-dupe-keys: 2
-  no-duplicate-case: 2
-  no-empty-character-class: 2
-  no-ex-assign: 2
-  no-extra-boolean-cast: 2
-  no-extra-parens: [2, functions]
-  no-extra-semi: 2
-  no-func-assign: 2
-  no-invalid-regexp: 2
-  no-irregular-whitespace: 2
-  no-obj-calls: 2
-  no-proto: 2
-  no-template-curly-in-string: 2
-  no-unexpected-multiline: 2
-  no-unreachable: 2
-  no-unsafe-negation: 2
-  use-isnan: 2
-  valid-typeof: 2
+  comma-dangle: [error, only-multiline]
+  no-control-regex: error
+  no-debugger: error
+  no-dupe-args: error
+  no-dupe-keys: error
+  no-duplicate-case: error
+  no-empty-character-class: error
+  no-ex-assign: error
+  no-extra-boolean-cast: error
+  no-extra-parens: [error, functions]
+  no-extra-semi: error
+  no-func-assign: error
+  no-invalid-regexp: error
+  no-irregular-whitespace: error
+  no-obj-calls: error
+  no-proto: error
+  no-template-curly-in-string: error
+  no-unexpected-multiline: error
+  no-unreachable: error
+  no-unsafe-negation: error
+  use-isnan: error
+  valid-typeof: error
 
   # Best Practices
   # http://eslint.org/docs/rules/#best-practices
-  dot-location: [2, property]
-  no-fallthrough: 2
-  no-global-assign: 2
-  no-multi-spaces: [2, {ignoreEOLComments: true}]
-  no-octal: 2
-  no-redeclare: 2
-  no-self-assign: 2
-  no-unused-labels: 2
-  no-useless-call: 2
-  no-useless-concat: 2
-  no-useless-escape: 2
-  no-useless-return: 2
-  no-void: 2
-  no-with: 2
+  dot-location: [error, property]
+  no-fallthrough: error
+  no-global-assign: error
+  no-multi-spaces: [error, {ignoreEOLComments: true}]
+  no-octal: error
+  no-redeclare: error
+  no-self-assign: error
+  no-unused-labels: error
+  no-useless-call: error
+  no-useless-concat: error
+  no-useless-escape: error
+  no-useless-return: error
+  no-void: error
+  no-with: error
 
   # Strict Mode
   # http://eslint.org/docs/rules/#strict-mode
-  strict: [2, global]
+  strict: [error, global]
 
   # Variables
   # http://eslint.org/docs/rules/#variables
-  no-delete-var: 2
-  no-undef: 2
-  no-unused-vars: [2, {args: none}]
-  no-use-before-define: [2, {classes: true,
-                             functions: false,
-                             variables: false}]
+  no-delete-var: error
+  no-undef: error
+  no-unused-vars: [error, {args: none}]
+  no-use-before-define: [error, {classes: true,
+                                 functions: false,
+                                 variables: false}]
 
   # Node.js and CommonJS
   # http://eslint.org/docs/rules/#nodejs-and-commonjs
-  no-mixed-requires: 2
-  no-new-require: 2
-  no-path-concat: 2
-  no-restricted-modules: [2, sys, _linklist]
+  no-mixed-requires: error
+  no-new-require: error
+  no-path-concat: error
+  no-restricted-modules: [error, sys, _linklist]
   no-restricted-properties:
-    - 2
+    - error
     - object: assert
       property: deepEqual
       message: Use assert.deepStrictEqual().
@@ -90,33 +90,39 @@ rules:
 
   # Stylistic Issues
   # http://eslint.org/docs/rules/#stylistic-issues
-  block-spacing: 2
-  brace-style: [2, 1tbs, {allowSingleLine: true}]
-  comma-spacing: 2
-  comma-style: 2
-  computed-property-spacing: 2
-  eol-last: 2
-  func-call-spacing: 2
-  func-name-matching: 2
-  func-style: [2, declaration, {allowArrowFunctions: true}]
-  indent: [2, 2, {ArrayExpression: first,
-                  CallExpression: {arguments: first},
-                  FunctionDeclaration: {parameters: first},
-                  FunctionExpression: {parameters: first},
-                  MemberExpression: off,
-                  ObjectExpression: first,
-                  SwitchCase: 1}]
-  key-spacing: [2, {mode: minimum}]
-  keyword-spacing: 2
-  linebreak-style: [2, unix]
-  max-len: [2, {code: 80,
-                ignoreRegExpLiterals: true,
-                ignoreUrls: true,
-                tabWidth: 2}]
-  new-parens: 2
-  no-mixed-spaces-and-tabs: 2
-  no-multiple-empty-lines: [2, {max: 2, maxEOF: 0, maxBOF: 0}]
-  no-restricted-syntax: [2, {
+  block-spacing: error
+  brace-style: [error, 1tbs, {allowSingleLine: true}]
+  comma-spacing: error
+  comma-style: error
+  computed-property-spacing: error
+  eol-last: error
+  func-call-spacing: error
+  func-name-matching: error
+  func-style: [error, declaration, {allowArrowFunctions: true}]
+  indent: [error, 2, {ArrayExpression: first,
+                      CallExpression: {arguments: first},
+                      FunctionDeclaration: {parameters: first},
+                      FunctionExpression: {parameters: first},
+                      MemberExpression: off,
+                      ObjectExpression: first,
+                      SwitchCase: 1}]
+  key-spacing: [error, {mode: minimum}]
+  keyword-spacing: error
+  linebreak-style: [error, unix]
+  max-len: [error, {code: 80,
+                    ignoreRegExpLiterals: true,
+                    ignoreUrls: true,
+                    tabWidth: 2}]
+  new-parens: error
+  no-mixed-spaces-and-tabs: error
+  no-multiple-empty-lines: [error, {max: 2, maxEOF: 0, maxBOF: 0}]
+  no-restricted-syntax: [error, {
+    selector: "CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.1.type='Literal']:not([arguments.1.regex])",
+    message: "use a regular expression for second argument of assert.throws()"
+  }, {
+    selector: "CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.length<2]",
+    message: "assert.throws() must be invoked with at least two arguments."
+  }, {
     selector: "CallExpression[callee.name='setTimeout'][arguments.length<2]",
     message: "setTimeout() must be invoked with at least two arguments."
   }, {
@@ -129,39 +135,38 @@ rules:
     selector: "CallExpression[callee.object.name='assert'][callee.property.name='fail'][arguments.length=1]",
     message: "assert.fail() message should be third argument"
   }]
-  no-tabs: 2
-  no-trailing-spaces: 2
-  operator-linebreak: [2, after, {overrides: {'?': ignore, ':': ignore}}]
-  quotes: [2, single, avoid-escape]
-  semi: 2
-  semi-spacing: 2
-  space-before-blocks: [2, always]
-  space-before-function-paren: [2, {
+  no-tabs: error
+  no-trailing-spaces: error
+  operator-linebreak: [error, after, {overrides: {'?': ignore, ':': ignore}}]
+  quotes: [error, single, avoid-escape]
+  semi: error
+  semi-spacing: error
+  space-before-blocks: [error, always]
+  space-before-function-paren: [error, {
     "anonymous": "never",
     "named": "never",
     "asyncArrow": "always"
   }]
-  space-in-parens: [2, never]
-  space-infix-ops: 2
-  space-unary-ops: 2
+  space-in-parens: [error, never]
+  space-infix-ops: error
+  space-unary-ops: error
 
   # ECMAScript 6
   # http://eslint.org/docs/rules/#ecmascript-6
-  arrow-parens: [2, always]
-  arrow-spacing: [2, {before: true, after: true}]
-  constructor-super: 2
-  no-class-assign: 2
-  no-confusing-arrow: 2
-  no-const-assign: 2
-  no-dupe-class-members: 2
-  no-new-symbol: 2
-  no-this-before-super: 2
-  prefer-const: [2, {ignoreReadBeforeAssign: true}]
-  rest-spread-spacing: 2
-  template-curly-spacing: 2
+  arrow-parens: [error, always]
+  arrow-spacing: [error, {before: true, after: true}]
+  constructor-super: error
+  no-class-assign: error
+  no-confusing-arrow: error
+  no-const-assign: error
+  no-dupe-class-members: error
+  no-new-symbol: error
+  no-this-before-super: error
+  prefer-const: [error, {ignoreReadBeforeAssign: true}]
+  rest-spread-spacing: error
+  template-curly-spacing: error
 
   # Custom rules in tools/eslint-rules
-  assert-throws-arguments: [2, { requireTwo: true }]
 
 # Global scoped method and vars
 globals:

BUILDING.md

@@ -94,6 +94,8 @@ More Developer Tools...`. This step will install `clang`, `clang++`, and
 * You may want to setup [firewall rules](tools/macosx-firewall.sh)
 to avoid popups asking to accept incoming network connections when running tests:
 
+If the path to your build directory contains a space, the build will likely fail.
+
 ```console
 $ sudo ./tools/macosx-firewall.sh
 ```
@@ -127,6 +129,25 @@ To run the tests:
 $ make test
 ```
 
+To run the tests and generate code coverage reports:
+
+```console
+$ ./configure --coverage
+$ make coverage
+```
+
+This will generate coverage reports for both JavaScript and C++ tests (if you
+only want to run the JavaScript tests then you do not need to run the first
+command `./configure --coverage`).
+
+The `make coverage` command downloads some tools to the project root directory
+and overwrites the `lib/` directory. To clean up after generating the coverage
+reports:
+
+```console
+make coverage-clean
+```
+
 To build the documentation:
 
 This will build Node.js first (if necessary) and then use it to build the docs:
@@ -135,7 +156,7 @@ This will build Node.js first (if necessary) and then use it to build the docs:
 $ make doc
 ```
 
-If you have an existing Node.js you can build just the docs with:
+If you have an existing Node.js build, you can build just the docs with:
 
 ```console
 $ NODE=/path/to/node make doc-only
@@ -174,6 +195,8 @@ Prerequisites:
   [Git for Windows](http://git-scm.com/download/win) includes Git Bash
   and tools which can be included in the global `PATH`.
 
+If the path to your build directory contains a space, the build will likely fail.
+
 ```console
 > .\vcbuild nosign
 ```

CHANGELOG.md

@@ -26,7 +26,8 @@ release.
 </tr>
 <tr>
   <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V6.md#6.11.3">6.11.3</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V6.md#6.11.4">6.11.4</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V6.md#6.11.3">6.11.3</a><br/>
 <a href="doc/changelogs/CHANGELOG_V6.md#6.11.2">6.11.2</a><br/>
 <a href="doc/changelogs/CHANGELOG_V6.md#6.11.1">6.11.1</a><br/>
 <a href="doc/changelogs/CHANGELOG_V6.md#6.11.0">6.11.0</a><br/>