-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
errors: replace .split()
with .replace()
#15545
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace a somewhat idiosyncratic use of `split()` to remove a prefix with `replace()`. (A case could be made for `slice()` as well but I think this is more readable.)
Fishrock123
approved these changes
Sep 21, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm if ci looks good
cjihrig
approved these changes
Sep 21, 2017
TimothyGu
approved these changes
Sep 22, 2017
lpinca
approved these changes
Sep 22, 2017
BridgeAR
approved these changes
Sep 24, 2017
Landed in 55d49eb |
BridgeAR
pushed a commit
that referenced
this pull request
Sep 24, 2017
Replace a somewhat idiosyncratic use of `split()` to remove a prefix with `replace()`. (A case could be made for `slice()` as well but I think this is more readable.) PR-URL: #15545 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This does not land cleanly in v8.x-staging, a backport would be needed. I believe it depends on a previous semver-major. |
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 30, 2017
Replace a somewhat idiosyncratic use of `split()` to remove a prefix with `replace()`. (A case could be made for `slice()` as well but I think this is more readable.) PR-URL: nodejs/node#15545 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace a somewhat idiosyncratic use of
split()
to remove a prefixwith
replace()
. (A case could be made forslice()
as well but Ithink this is more readable.)
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
errors