Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: remove unused variable #15614

Closed
wants to merge 1 commit into from
Closed

url: remove unused variable #15614

wants to merge 1 commit into from

Conversation

sam-github
Copy link
Contributor

I'm rebuilding to bisect, its possible this was a side-effect of #15490

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

url,src

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Sep 25, 2017
@sam-github
Copy link
Contributor Author

ci: https://ci.nodejs.org/job/node-test-pull-request/10258/

@addaleax addaleax added the duplicate Issues and PRs that are duplicates of other issues or PRs. label Sep 25, 2017
@addaleax
Copy link
Member

Duplicate of #15592, can this be closed?

@sam-github sam-github closed this Sep 25, 2017
@sam-github sam-github deleted the remove-unused-var branch September 25, 2017 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eugeneo eugeneo eugeneo approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. duplicate Issues and PRs that are duplicates of other issues or PRs. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sam-github @addaleax @eugeneo @nodejs-github-bot