Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused using in node_trace_writer.h #15646

Closed
wants to merge 1 commit into from
Closed

src: remove unused using in node_trace_writer.h #15646

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Sep 28, 2017

There is an unnecessary using TracingController in node_trace_writer.h
and this commit removes it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@danbev
src: remove unused using in node_trace_writer.h
7429a53 
There is an unnecessary using TracingController in node_trace_writer.h
and this commit removes it.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. labels Sep 28, 2017
@danbev
Copy link
Contributor Author

danbev commented Sep 28, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10303/

jasnell pushed a commit that referenced this pull request Sep 29, 2017
@danbev @jasnell
src: remove unused using in node_trace_writer.h
e0edb00 
There is an unnecessary using TracingController in node_trace_writer.h
and this commit removes it.

PR-URL: #15646
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@jasnell
Copy link
Member

jasnell commented Sep 29, 2017

Landed in e0edb00

@jasnell jasnell closed this Sep 29, 2017
MylesBorins pushed a commit that referenced this pull request Sep 29, 2017
@danbev @MylesBorins
src: remove unused using in node_trace_writer.h
0a45a0c 
There is an unnecessary using TracingController in node_trace_writer.h
and this commit removes it.

PR-URL: #15646
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 30, 2017
@danbev @addaleax
src: remove unused using in node_trace_writer.h
e6a767e 
There is an unnecessary using TracingController in node_trace_writer.h
and this commit removes it.

PR-URL: nodejs/node#15646
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@danbev @MylesBorins
src: remove unused using in node_trace_writer.h
0043c25 
There is an unnecessary using TracingController in node_trace_writer.h
and this commit removes it.

PR-URL: #15646
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorins MylesBorins mentioned this pull request Oct 3, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@danbev @MylesBorins
src: remove unused using in node_trace_writer.h
91afa74 
There is an unnecessary using TracingController in node_trace_writer.h
and this commit removes it.

PR-URL: #15646
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@danbev @MylesBorins
src: remove unused using in node_trace_writer.h
7e1003a 
There is an unnecessary using TracingController in node_trace_writer.h
and this commit removes it.

PR-URL: #15646
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danbev danbev deleted the remove-unused-TracingController branch November 16, 2017 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@danbev @jasnell @lpinca @cjihrig @tniessen @MylesBorins @nodejs-github-bot