doc: add 'git clean' to backport guide #15715
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibfahn
approved these changes
Oct 1, 2017
|
cc/ @nodejs/backporting |
refack
reviewed
Oct 2, 2017
| @@ -44,6 +44,8 @@ cd $NODE_DIR | |||
| git fetch upstream v6.x-staging:v6.x-staging -f | |||
| # Assume we want to backport PR #10157 | |||
| git checkout -b backport-10157-to-v6.x v6.x-staging | |||
| # Ensure there are no build artifacts from previous builds | |||
| git clean -xfd | |||
There was a problem hiding this comment.
This is a "dangerous" command, it removes everything including draft files and IDE metadata.
I'd suggest mark it as optional, and add a warning.
Also AFAIK the only problematic area is ./test so maybe just:
git clean -xdf ./test/
|
@refack updated wording ptal. |
jasnell
approved these changes
Oct 2, 2017
danbev
approved these changes
Oct 2, 2017
lance
added a commit
that referenced
this pull request
Oct 2, 2017
When changing from a recent version, e.g. 8.x to an older branch like 6.x test artifacts sometimes hang around and cause failures. Using `git clean` will prevent that from happening. PR-URL: #15715 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
|
Landed in: e517bc9 |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 3, 2017
When changing from a recent version, e.g. 8.x to an older branch like 6.x test artifacts sometimes hang around and cause failures. Using `git clean` will prevent that from happening. PR-URL: #15715 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Oct 3, 2017
When changing from a recent version, e.g. 8.x to an older branch like 6.x test artifacts sometimes hang around and cause failures. Using `git clean` will prevent that from happening. PR-URL: #15715 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 4, 2017
When changing from a recent version, e.g. 8.x to an older branch like 6.x test artifacts sometimes hang around and cause failures. Using `git clean` will prevent that from happening. PR-URL: nodejs/node#15715 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
When changing from a recent version, e.g. 8.x to an older branch like 6.x test artifacts sometimes hang around and cause failures. Using `git clean` will prevent that from happening. PR-URL: #15715 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 17, 2017
When changing from a recent version, e.g. 8.x to an older branch like 6.x test artifacts sometimes hang around and cause failures. Using `git clean` will prevent that from happening. PR-URL: #15715 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Oct 25, 2017
When changing from a recent version, e.g. 8.x to an older branch like 6.x test artifacts sometimes hang around and cause failures. Using `git clean` will prevent that from happening. PR-URL: #15715 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a line to the backporting guide for
git clean. Sometimes not all of the build artifacts from more recent versions have been cleaned up. Make sure folks don't get tripped up by this.Checklist
Affected core subsystem(s)
doc