repl: do not save history for non-terminal repl

[indutny]

When running in non-TTY mode - the repl.history is undefined and
is not actually populated. Saving it will result in a crashes of
subsequent repl runs.

Fix: #1574

[indutny]

R=@chrisdickinson

[chrisdickinson]

LGTM, sorry this slipped through.

[indutny]

@chrisdickinson I had some time to think about it... What is your opinion on ignore JSON.parse errors and emptying the history? I think it is better than crashing the repl, do you agree?

[chrisdickinson]

I think my preference would be to note that we couldn't load history and that support will be disabled until the file is fixed (or removed.)

On May 1, 2015, at 10:54 AM, Fedor Indutny notifications@github.com wrote:

@chrisdickinson I had some time to think about it... What is your opinion on ignore JSON.parse errors and emptying the history? I think it is better than crashing the repl, do you agree?

—
Reply to this email directly or view it on GitHub.

[indutny]

Why? Who cares about preserving the history?

[chrisdickinson]

My reasoning is:

1. it could be pointed at an unintended file, or,
2. it could somehow have been caught in a bad state (reading a half-written file, perhaps!), or,
3. it might be the result of a bug in io.js in which case having the output of the file would be useful.

In any case I'd prefer to let the user be the one to blow away the file on error, in case they're relying on the persistent history to "save" their work.

[indutny]

Landed in ea5195c, thank you!