Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make use of common/fixtures.fixturesDir #15815

Closed
wants to merge 2 commits into from
Closed

test: make use of common/fixtures.fixturesDir #15815

wants to merge 2 commits into from

Conversation

jemjam
Copy link

@jemjam jemjam commented Oct 6, 2017 •
edited
Loading

The common/fixtures module provides convenience methods for working with
files in the test/fixtures directory. Make use of the fixturesDir
value from module rather than value from common.

  • Replace common.fixtures with fixtures.fixturesDir
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test: make use of common/fixtures.fixturesDir
78c2b1e 
The common/fixtures module provides convenience methods for working with
files in the test/fixtures directory. Make use of the `fixturesDir`
value from module rather than value from common.

- Replace `common.fixtures` with `fixtures.fixturesDir`
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@mscdex mscdex added the crypto Issues and PRs related to the crypto subsystem. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 7, 2017
lpinca
lpinca reviewed Oct 9, 2017
View reviewed changes
test/pummel/test-crypto-timing-safe-equal-benchmarks.js Outdated
@@ -1,5 +1,6 @@
'use strict';
const common = require('../common');
const fixtures = require('../common/fixtures');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: would you mind to move this after the common.skip() conditions?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to. 👍

tniessen
tniessen approved these changes Oct 9, 2017
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would be great if you could address @lpinca's comment.

@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10649/

jasnell pushed a commit that referenced this pull request Oct 13, 2017
@jasnell
test: make use of common/fixtures.fixturesDir
c4231aa 
The common/fixtures module provides convenience methods for working with
files in the test/fixtures directory. Make use of the `fixturesDir`
value from module rather than value from common.

- Replace `common.fixtures` with `fixtures.fixturesDir`

PR-URL: #15815
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Oct 13, 2017

Landed in c4231aa

@jasnell jasnell closed this Oct 13, 2017
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 15, 2017
@addaleax
test: make use of common/fixtures.fixturesDir
6006c45 
The common/fixtures module provides convenience methods for working with
files in the test/fixtures directory. Make use of the `fixturesDir`
value from module rather than value from common.

- Replace `common.fixtures` with `fixtures.fixturesDir`

PR-URL: nodejs/node#15815
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 18, 2017
@targos
test: make use of common/fixtures.fixturesDir
529e685 
The common/fixtures module provides convenience methods for working with
files in the test/fixtures directory. Make use of the `fixturesDir`
value from module rather than value from common.

- Replace `common.fixtures` with `fixtures.fixturesDir`

PR-URL: #15815
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@MylesBorins
test: make use of common/fixtures.fixturesDir
1cd910b 
The common/fixtures module provides convenience methods for working with
files in the test/fixtures directory. Make use of the `fixturesDir`
value from module rather than value from common.

- Replace `common.fixtures` with `fixtures.fixturesDir`

PR-URL: #15815
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@MylesBorins
test: make use of common/fixtures.fixturesDir
f223800 
The common/fixtures module provides convenience methods for working with
files in the test/fixtures directory. Make use of the `fixturesDir`
value from module rather than value from common.

- Replace `common.fixtures` with `fixtures.fixturesDir`

PR-URL: #15815
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@MylesBorins
test: make use of common/fixtures.fixturesDir
57590cd 
The common/fixtures module provides convenience methods for working with
files in the test/fixtures directory. Make use of the `fixturesDir`
value from module rather than value from common.

- Replace `common.fixtures` with `fixtures.fixturesDir`

PR-URL: #15815
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

@rmg rmg rmg approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.