doc: add back macosx-firewall suggestion into BUILDING.md #15829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding back the changes made by commit# 791d560, that suggests running macosx-firewall.sh script after bulid step. These changes were delete by commit# fc102d0, but they are still applicable.
nodejs-github-bot
added
build
rmg
approved these changes
Oct 6, 2017
Trott
added
the
code-and-learn
cjihrig
approved these changes
Oct 7, 2017
benjamingr
approved these changes
Oct 7, 2017
lpinca
approved these changes
Oct 9, 2017
danbev
approved these changes
Oct 9, 2017
danbev
pushed a commit
to danbev/node
that referenced
this pull request
Oct 9, 2017
Adding back the changes made by commit# 791d560, that suggests running macosx-firewall.sh script after bulid step. These changes were deleted by commit# fc102d0, but they are still applicable. PR-URL: nodejs#15829 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
|
Landed in e8bf4d5. Thanks! |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
Adding back the changes made by commit# 791d560, that suggests running macosx-firewall.sh script after bulid step. These changes were deleted by commit# fc102d0, but they are still applicable. PR-URL: #15829 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Merged
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
Adding back the changes made by commit# 791d560, that suggests running macosx-firewall.sh script after bulid step. These changes were deleted by commit# fc102d0, but they are still applicable. PR-URL: nodejs/node#15829 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 17, 2017
Adding back the changes made by commit# 791d560, that suggests running macosx-firewall.sh script after bulid step. These changes were deleted by commit# fc102d0, but they are still applicable. PR-URL: #15829 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Oct 18, 2017
Adding back the changes made by commit# 791d560, that suggests running macosx-firewall.sh script after bulid step. These changes were deleted by commit# fc102d0, but they are still applicable. PR-URL: #15829 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 25, 2017
Adding back the changes made by commit# 791d560, that suggests running macosx-firewall.sh script after bulid step. These changes were deleted by commit# fc102d0, but they are still applicable. PR-URL: #15829 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding back the changes made by commit# 791d560, that suggests running macosx-firewall.sh script after bulid step. These changes were delete by commit# fc102d0, but they are still applicable.
Checklist
Affected core subsystem(s)
doc