Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update fixtures use #15855

Closed
wants to merge 1 commit into from
Closed

test: update fixtures use #15855

wants to merge 1 commit into from

Conversation

ruxandrafed
Copy link
Contributor

@ruxandrafed ruxandrafed commented Oct 6, 2017 •
edited
Loading

This commit replaces the use of common.fixturesDir with common.fixtures & fixtures.path in test-fs-read-stream-resume.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@ruxandrafed
test: normalize fixtures use
66e5d25 
This commit replaces the use of `common.fixturesDir` with `common.fixtures` & `fixtures.path` in `test-fs-read-stream-resume.js`
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@ruxandrafed ruxandrafed changed the title test: normalize fixtures use test: update fixtures use Oct 9, 2017
@refack refack self-assigned this Oct 10, 2017
gireeshpunathil
gireeshpunathil approved these changes Oct 11, 2017
View reviewed changes
Copy link
Member

@gireeshpunathil gireeshpunathil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI: https://ci.nodejs.org/job/node-test-pull-request/10598/

@joyeecheung
Copy link
Member

Landed in e791057, thank you for the contribution!

joyeecheung pushed a commit that referenced this pull request Oct 11, 2017
@ruxandrafed @joyeecheung
test: normalize fixtures use
e791057 
This commit replaces the use of `common.fixturesDir`
with `common.fixtures` & `fixtures.path` in
`test-fs-read-stream-resume.js`

PR-URL: #15855
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@ruxandrafed @addaleax
test: normalize fixtures use
5bb3f01 
This commit replaces the use of `common.fixturesDir`
with `common.fixtures` & `fixtures.path` in
`test-fs-read-stream-resume.js`

PR-URL: nodejs/node#15855
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit that referenced this pull request Oct 18, 2017
@ruxandrafed @targos
test: normalize fixtures use
99ef152 
This commit replaces the use of `common.fixturesDir`
with `common.fixtures` & `fixtures.path` in
`test-fs-read-stream-resume.js`

PR-URL: #15855
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit that referenced this pull request Oct 18, 2017
@ruxandrafed @targos
test: normalize fixtures use
64a1c1f 
This commit replaces the use of `common.fixturesDir`
with `common.fixtures` & `fixtures.path` in
`test-fs-read-stream-resume.js`

PR-URL: #15855
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Nov 15, 2017
@ruxandrafed @MylesBorins
test: normalize fixtures use
4d7b5af 
This commit replaces the use of `common.fixturesDir`
with `common.fixtures` & `fixtures.path` in
`test-fs-read-stream-resume.js`

PR-URL: #15855
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@ruxandrafed @MylesBorins
test: normalize fixtures use
1c672b4 
This commit replaces the use of `common.fixturesDir`
with `common.fixtures` & `fixtures.path` in
`test-fs-read-stream-resume.js`

PR-URL: #15855
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@ruxandrafed @MylesBorins
test: normalize fixtures use
c35420d 
This commit replaces the use of `common.fixturesDir`
with `common.fixtures` & `fixtures.path` in
`test-fs-read-stream-resume.js`

PR-URL: #15855
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@refack refack removed their assignment Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.