Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sequential: replace fixturesDir to fixtures.path() #15863

Closed
wants to merge 1 commit into from
Closed

Sequential: replace fixturesDir to fixtures.path() #15863

wants to merge 1 commit into from

Conversation

akiokio
Copy link
Contributor

@akiokio akiokio commented Oct 6, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

None

@akiokio
test: change fixturesDir to fixtures.path
204e4c5 
Using fixtures.path allows us to pass args to fixturesDir

None
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@mscdex mscdex added the module Issues and PRs related to the module subsystem. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@Trott
Copy link
Member

Trott commented Oct 8, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10500/

lpinca
lpinca approved these changes Oct 10, 2017
View reviewed changes
test/sequential/test-init.js
@@ -49,7 +49,7 @@ function test(file, expected) {

{
// test-init-index is in fixtures dir as requested by ry, so go there
process.chdir(common.fixturesDir);
process.chdir(fixtures.path());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this works but it could simply be fixtures.fixturesDir.

Trott pushed a commit to Trott/io.js that referenced this pull request Oct 11, 2017
@akiokio @Trott
test: change fixturesDir to fixtures.path
f170f84 
PR-URL: nodejs#15863
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Copy link
Member

Trott commented Oct 11, 2017

Landed in f170f84.

Thanks for the contribution! 🎉

@Trott Trott closed this Oct 11, 2017
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@akiokio @addaleax
test: change fixturesDir to fixtures.path
dd68e9d 
PR-URL: nodejs/node#15863
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Oct 18, 2017
@akiokio @targos
test: change fixturesDir to fixtures.path
d20f8d3 
PR-URL: #15863
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 15, 2017
@akiokio @MylesBorins
test: change fixturesDir to fixtures.path
7274258 
PR-URL: #15863
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@akiokio @MylesBorins
test: change fixturesDir to fixtures.path
743cb9c 
PR-URL: #15863
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@akiokio @MylesBorins
test: change fixturesDir to fixtures.path
095df35 
PR-URL: #15863
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. module Issues and PRs related to the module subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@akiokio @Trott @jasnell @lpinca @gibfahn @mscdex @MylesBorins @nodejs-github-bot