adding tested values on fail condition message at test/parallel/test-vm-symbols.js #15873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test-vm-symbols.js
Trott
added
the
code-and-learn
|
Hi, @jungleBadger! Welcome and thanks for this. I don't think it's a good idea to insert all those indentation spaces inside the template literal. If you want to keep it with all that text, you can use |
joyeecheung
reviewed
Oct 11, 2017
test/parallel/test-vm-symbols.js
Outdated
| @@ -19,7 +19,9 @@ const context = new Document(); | |||
| vm.createContext(context); | |||
|
|
|||
| assert.strictEqual(context.getSymbolValue(), 'foo', | |||
| 'should return symbol-keyed value from the outside'); | |||
| `should return symbol-keyed value from the outside. | |||
There was a problem hiding this comment.
It would be better if we just remove the assertion message (third arugment) here.
test/parallel/test-vm-symbols.js
Outdated
|
|
||
| assert.strictEqual(vm.runInContext('this.getSymbolValue()', context), 'foo', | ||
| 'should return symbol-keyed value from the inside'); | ||
| `should return symbol-keyed value from the inside. |
|
Ping @jungleBadger |
|
Hi! Thanks for the feedback and I totally agree. Will make the changes and send it again |
…test-vm-symbols.js
BridgeAR
approved these changes
Oct 19, 2017
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Oct 19, 2017
PR-URL: nodejs#15873 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Landed in 708084a Thanks for the PR and congratulations on becoming a Node.js Contributor 🎉 ! |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 23, 2017
PR-URL: #15873 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
PR-URL: nodejs/node#15873 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
PR-URL: #15873 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
PR-URL: #15873 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
PR-URL: #15873 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
PR-URL: nodejs/node#15873 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes