-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added DS_Store to gitignore #159
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why this request still open? I guess #162 (comment) was quite reasoned. |
Right, closing. Thanks for the pull request but there is no need to change this in io.js when it can be done from the global .gitignore. |
2 tasks
This was referenced Jul 20, 2020
This was referenced Dec 1, 2020
This was referenced Nov 30, 2023
eti-p-doray
pushed a commit
to eti-p-doray/node
that referenced
this pull request
Dec 5, 2023
Co-authored-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
eti-p-doray
pushed a commit
to eti-p-doray/node
that referenced
this pull request
May 28, 2024
Co-authored-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
syg
pushed a commit
to syg/node
that referenced
this pull request
Jun 20, 2024
Co-authored-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> # Conflicts: # test/parallel/parallel.status
eti-p-doray
pushed a commit
to eti-p-doray/node
that referenced
this pull request
Aug 28, 2024
Co-authored-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> # Conflicts: # test/parallel/parallel.status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.