test: replaced common.fixturesDir with common.fixtures in test-process-redirect-warnings-env #15930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rect-warnings-env
frkat
changed the title
Trott
added
the
code-and-learn
BridgeAR
reviewed
Oct 8, 2017
| const fs = require('fs'); | ||
| const fork = require('child_process').fork; | ||
| const path = require('path'); | ||
| const assert = require('assert'); | ||
|
|
||
| common.refreshTmpDir(); | ||
|
|
||
| const warnmod = require.resolve(`${common.fixturesDir}/warnings.js`); | ||
| const warnmod = require.resolve(`${fixtures.fixturesDir}/warnings.js`); |
There was a problem hiding this comment.
This should probably be replaced with fixtures.path("/warnings.js")
There was a problem hiding this comment.
@BridgeAR Indeed. Thanks
jasnell
approved these changes
Oct 9, 2017
lpinca
reviewed
Oct 13, 2017
| const fs = require('fs'); | ||
| const fork = require('child_process').fork; | ||
| const path = require('path'); | ||
| const assert = require('assert'); | ||
|
|
||
| common.refreshTmpDir(); | ||
|
|
||
| const warnmod = require.resolve(`${common.fixturesDir}/warnings.js`); | ||
| const warnmod = require.resolve(fixtures.path('/warnings.js')); |
There was a problem hiding this comment.
This could be just fixtures.path('warnings.js').
|
Failures in CI are unrelated. |
jasnell
pushed a commit
that referenced
this pull request
Oct 13, 2017
Replaced common.fixturesDir with common.fixtures in test-process-redirect-warnings-env PR-URL: #15930 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in ab6eed8. |
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
Replaced common.fixturesDir with common.fixtures in test-process-redirect-warnings-env PR-URL: nodejs/node#15930 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
Replaced common.fixturesDir with common.fixtures in test-process-redirect-warnings-env PR-URL: #15930 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
Replaced common.fixturesDir with common.fixtures in test-process-redirect-warnings-env PR-URL: #15930 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
Replaced common.fixturesDir with common.fixtures in test-process-redirect-warnings-env PR-URL: #15930 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
Replaced common.fixturesDir with common.fixtures in test-process-redirect-warnings-env PR-URL: #15930 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)