test: add tls.connect js stream write test #1594
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| stream = require('stream'), | ||
| net = require('net'); | ||
|
|
||
| var common = require('../common.js'); |
There was a problem hiding this comment.
common instead of common.js please?
mscdex
force-pushed
the
test-tls-connect-stream-writes
branch
from
b6d5bc9
to
de00acf
Compare
mscdex
added
tls
shigeki
pushed a commit
to shigeki/node
that referenced
this pull request
May 6, 2015
The index of buffer to write in JSStream was always 0 by mistake. This fix was to use increment index of buffer arrays. The test was originally made by Brian White in nodejs#1594. Fixes: nodejs#1595 Fixes: nodejs#1594
|
This was merged in as a part of #1635 . |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
May 19, 2015
The index of buffer to write in JSStream was always 0 by mistake. This fix was to use increment index of buffer arrays. The test was originally made by Brian White in nodejs#1594. Fix: nodejs#1595 Fix: nodejs#1594 PR-URL: nodejs#1635 Reviewed-By: Fedor Indutny <fedor@indutny.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests for an OpenSSL error with many tls socket writes with js streams.