Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace string concatenation with template literal #15969

Closed
wants to merge 2 commits into from
Closed

test: replace string concatenation with template literal #15969

wants to merge 2 commits into from

Conversation

chrisbudy
Copy link
Contributor

@chrisbudy chrisbudy commented Oct 6, 2017 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@chrisbudy chrisbudy changed the title replace string concatenation with template literal and const order change test: replace string concatenation with template literal Oct 6, 2017
@mscdex mscdex added the repl Issues and PRs related to the REPL subsystem. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 7, 2017
BridgeAR
BridgeAR approved these changes Oct 7, 2017
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the commit message should be changed while landing. As far as I see it it is not about the string concatenation but instead about using the defaultHistoryPath instead of using path.join later on again with the same input.

@BridgeAR
Copy link
Member

BridgeAR commented Oct 7, 2017

CI https://ci.nodejs.org/job/node-test-pull-request/10474/

@BridgeAR BridgeAR self-assigned this Oct 8, 2017
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 8, 2017
@chrisbudy @BridgeAR
test: use defaultHistoryPath instead of path.join
ab3c84f 
PR-URL: nodejs#15969
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
Copy link
Member

BridgeAR commented Oct 8, 2017

Landed in ab3c84f

Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 !

@BridgeAR BridgeAR closed this Oct 8, 2017
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@chrisbudy @MylesBorins
test: use defaultHistoryPath instead of path.join
b564fe2 
PR-URL: #15969
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Oct 11, 2017
Merged
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@chrisbudy @addaleax
test: use defaultHistoryPath instead of path.join
4d20471 
PR-URL: nodejs/node#15969
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees

@BridgeAR BridgeAR

Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chrisbudy @BridgeAR @mscdex @MylesBorins @Trott @nodejs-github-bot