test: include value to assert message #15970
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
the
code-and-learn
BridgeAR
reviewed
Oct 7, 2017
| @@ -20,13 +23,13 @@ assert.strictEqual(zlib.gunzipSync(data).toString(), 'abcdef'); | |||
| zlib.gunzip(data, common.mustCall((err, result) => { | |||
| assert.ifError(err); | |||
| assert.strictEqual(result.toString(), 'abcdef', | |||
| 'result should match original string'); | |||
| 'result should match original string: ' + (abc + def)); | |||
There was a problem hiding this comment.
The more important part is actually what result.toString() looks like. Please change it to something like
`${result.toString()} should equal ${abc + def}`
|
Hi Ruben
Thanks for the comment
I have modified the code and checked in.
This is my first time contributing to Node. Please let me know if I missed any steps.
ThanksHazel
Sent from my Samsung Galaxy smartphone.
-------- Original message --------From: Ruben Bridgewater <notifications@github.com> Date: 10/7/17 10:47 AM (GMT-08:00) To: nodejs/node <node@noreply.github.com> Cc: hwaisiu <hazelsiu@gmail.com>, Author <author@noreply.github.com> Subject: Re: [nodejs/node] test: include value to assert message (#15970)
@BridgeAR commented on this pull request.
In test/parallel/test-zlib-from-concatenated-gzip.js:
@@ -20,13 +23,13 @@ assert.strictEqual(zlib.gunzipSync(data).toString(), 'abcdef');
zlib.gunzip(data, common.mustCall((err, result) => {
assert.ifError(err);
assert.strictEqual(result.toString(), 'abcdef',
- 'result should match original string');
+ 'result should match original string: ' + (abc + def));
The more important part is actually what result.toString() looks like. Please change it to something like
`${result.toString()} should equal ${abc + def}`
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/nodejs/node","title":"nodejs/node","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/nodejs/node"}},"updates":{"snippets":[{"icon":"PERSON","message":"@BridgeAR commented on #15970"}],"action":{"name":"View Pull Request","url":"#15970 (review)"}}}
|
|
@hwaisiu Hi, have you pushed your changes to your branch ( $ git checkout node-dev # or other branch name that you have in your local repo that points to this PR
# make changes
$ git commit --amend # You can leave the commit message as-is in the editor
$ git push --force hwaisiu node-dev # assuming "hwaisiu" is pointing to your forked repository |
added 3 commits
October 10, 2017 20:18
…ting First member
test: because of length limit of message
|
I got a 403 error after I entered: |
|
I think I have figured out how to push the changes. Thanks |
jasnell
approved these changes
Oct 12, 2017
joyeecheung
reviewed
Oct 12, 2017
| assert.strictEqual(result.toString(), 'abc', | ||
| 'result should match contents of first "member"'); | ||
| assert.strictEqual(result.toString(), abc, | ||
| `First "member": ${result.toString()} === ${abc}`); |
There was a problem hiding this comment.
I think this is actually more readable if the assertion message is removed.
BridgeAR
approved these changes
Oct 18, 2017
|
Just a note for a potential next PR - the commit messages do not follow the guidelines. |
BridgeAR
pushed a commit
that referenced
this pull request
Oct 19, 2017
PR-URL: #15970 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Landed in ef96b05 Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 ! |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 23, 2017
PR-URL: #15970 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
![https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open](https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open){kind=link}
PR-URL: nodejs/node#15970 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
PR-URL: #15970 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
PR-URL: #15970 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
PR-URL: #15970 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
PR-URL: nodejs/node#15970 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)