test: replace fixturesDir in tls-connect-no-host #15986
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtex
changed the title
dtex
changed the title
dtex
changed the title
Trott
added
the
code-and-learn
BridgeAR
approved these changes
Oct 6, 2017
jasnell
reviewed
Oct 9, 2017
| const cert = fs.readFileSync(path.join(common.fixturesDir, 'test_cert.pem')); | ||
| const key = fs.readFileSync(path.join(common.fixturesDir, 'test_key.pem')); | ||
| const cert = fs.readFileSync(fixtures.path('test_cert.pem')); | ||
| const key = fs.readFileSync(fixtures.path('test_key.pem')); |
There was a problem hiding this comment.
Hello @dtex ! This is good but can be made even better using fixtures.readSync, e.g.
const cert = fixtures.readSync('test_cert.pem');
const key = fixtures.readSync('test_key.pem');There was a problem hiding this comment.
Thanks for pointing me to that. I've made that update.
I went ahead and amended the existing commit rather than add a second for such a small change. I hope that's okay.
cjihrig
approved these changes
Oct 10, 2017
jasnell
approved these changes
Oct 12, 2017
|
@joyeecheung Is that something I need to take action on? |
|
@dtex ... nope! That's just our testing run. It's there for record keeping purposes. |
jasnell
pushed a commit
that referenced
this pull request
Oct 13, 2017
PR-URL: #15986 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in c0bba73. Thank you for the contribution and for participating in the code and learn! |
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
PR-URL: nodejs/node#15986 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
PR-URL: #15986 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
PR-URL: #15986 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
PR-URL: #15986 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
PR-URL: #15986 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: replace fixturesDir in test-tls-connect-no-host.js
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test