Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace common.fixturesDir with fixtures #16015

Closed
wants to merge 1 commit into from
Closed

test: replace common.fixturesDir with fixtures #16015

wants to merge 1 commit into from
+2 −1

Conversation

sharpstef
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@mscdex mscdex added the repl Issues and PRs related to the REPL subsystem. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 7, 2017
@danbev danbev self-assigned this Oct 11, 2017
@danbev
Copy link
Contributor

danbev commented Oct 11, 2017

Landed in 23b4bf8.
Thanks!

@danbev danbev closed this Oct 11, 2017
danbev pushed a commit that referenced this pull request Oct 11, 2017
@sharpstef @danbev
test: replace common.fixturesDir with fixtures
23b4bf8 
PR-URL: #16015
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@sharpstef sharpstef deleted the codenlearn2 branch October 11, 2017 20:57
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@sharpstef @addaleax
test: replace common.fixturesDir with fixtures
5aeda4d 
PR-URL: nodejs/node#16015
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 18, 2017
@sharpstef @targos
test: replace common.fixturesDir with fixtures
d7ec89c 
PR-URL: #16015
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 15, 2017
@sharpstef @MylesBorins
test: replace common.fixturesDir with fixtures
a52fe46 
PR-URL: #16015
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@sharpstef @MylesBorins
test: replace common.fixturesDir with fixtures
0702051 
PR-URL: #16015
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@sharpstef @MylesBorins
test: replace common.fixturesDir with fixtures
d70f9f6 
PR-URL: #16015
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

Assignees

@danbev danbev

Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sharpstef @danbev @jasnell @benjamingr @BridgeAR @mscdex @Trott @nodejs-github-bot