Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add results to assertion messages #16024

Closed
wants to merge 1 commit into from
Closed

test: add results to assertion messages #16024

wants to merge 1 commit into from

Conversation

kkwoker
Copy link
Contributor

@kkwoker kkwoker commented Oct 6, 2017

This commit also puts the first two tests in scope.
expected_result was being overwritten in the second test before the first test passes, creating a race condition.

Checklist
  • [x ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • [ x] commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Oct 6, 2017
@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10428/

@kkwoker
Copy link
Contributor Author

kkwoker commented Oct 6, 2017

I duplicated this PR in #16037, and have a better solution for cleaning up the assertion values

@kkwoker kkwoker closed this Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kkwoker @joyeecheung @Trott @nodejs-github-bot