doc: include V8 commit URL in V8 backport guide #16054
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MylesBorins
reviewed
Oct 6, 2017
doc/guides/maintaining-V8.md
Outdated
| @@ -196,7 +196,8 @@ Original commit message: | |||
| Review-Url: https://codereview.chromium.org/2159683002 | |||
| Cr-Commit-Position: refs/heads/master@{#37833} | |||
|
|
|||
| PR-URL: <pr link> | |||
| Commit: https://github.com/v8/v8/commit/a51f429772d1e796744244128c9feeab4c26a854 | |||
There was a problem hiding this comment.
Should this be Refs:?
brb getting more paint
There was a problem hiding this comment.
SGTM. Surprised you didn't ask for Ref: though...
|
I'm not sure we need that. You can already look at the changes at the |
Use `Commit:` for the V8 commit, and `PR-URL:` for the Node PR URL. Refs: nodejs#16053 (comment)
True, but that requires understanding of the Chromium pull request UI, which I find pretty opaque compared to the Github equivalent. |
|
Fair enough. I'm not against this change if it can help people. Note to self: update https://github.com/targos/update-v8 when this has landed. |
targos
approved these changes
Oct 6, 2017
cjihrig
approved these changes
Oct 6, 2017
evanlucas
approved these changes
Oct 7, 2017
BridgeAR
approved these changes
Oct 9, 2017
jasnell
approved these changes
Oct 9, 2017
|
Landed in 9f1e6e7, thanks! |
joyeecheung
pushed a commit
that referenced
this pull request
Oct 13, 2017
Use `Commit:` for the V8 commit, and `PR-URL:` for the Node PR URL. Refs: #16053 (comment) PR-URL: #16054 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
Use `Commit:` for the V8 commit, and `PR-URL:` for the Node PR URL. Refs: nodejs/node#16053 (comment) PR-URL: nodejs/node#16054 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
Use `Commit:` for the V8 commit, and `PR-URL:` for the Node PR URL. Refs: #16053 (comment) PR-URL: #16054 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
added a commit
to targos/update-v8
that referenced
this pull request
Oct 18, 2017
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
Use `Commit:` for the V8 commit, and `PR-URL:` for the Node PR URL. Refs: #16053 (comment) PR-URL: #16054 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
Use `Commit:` for the V8 commit, and `PR-URL:` for the Node PR URL. Refs: #16053 (comment) PR-URL: #16054 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
Use `Commit:` for the V8 commit, and `PR-URL:` for the Node PR URL. Refs: #16053 (comment) PR-URL: #16054 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Commit:for the V8 commit, andPR-URL:for the Node PR URL.Bikeshedding over
Commit:welcome.Refs: #16053 (comment)
Checklist
Affected core subsystem(s)
doc, v8
cc/ @nodejs/v8