Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix lint error #16145

Closed
wants to merge 1 commit into from
Closed

test: fix lint error #16145

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 11, 2017

Fix lint error introduced 03550a5c1e. Unused module fs is removed.

Refs: #15832 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Fix lint error introduced 03550a5c1e. Unused module `fs` is removed.

Refs: nodejs#15832 (comment)
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 11, 2017
@Trott
Copy link
Member Author

Trott commented Oct 11, 2017

Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on expediting

Trott added a commit to Trott/io.js that referenced this pull request Oct 11, 2017
Fix lint error introduced 03550a5c1e. Unused module `fs` is removed.

PR-URL: nodejs#16145
Ref: nodejs#15832 (comment)
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Copy link
Member Author

Trott commented Oct 11, 2017

Linter passes now. Landed in acb36ab

@Trott Trott closed this Oct 11, 2017
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
Fix lint error introduced 03550a5c1e. Unused module `fs` is removed.

PR-URL: nodejs/node#16145
Ref: nodejs/node#15832 (comment)
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Oct 18, 2017
Fix lint error introduced 03550a5c1e. Unused module `fs` is removed.

PR-URL: #16145
Ref: #15832 (comment)
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott Trott deleted the fix-linter-111 branch January 13, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants