build: use local node-gyp for benchmark addon #16160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the logic for building the benchmark/misc/function_call to the top-level Makefile and use our local copy of node-gyp. Fixes: nodejs#16154
nodejs-github-bot
added
the
build
joyeecheung
approved these changes
Oct 12, 2017
|
CI: https://ci.nodejs.org/job/node-test-pull-request/10646/ (not that this path is exercised by the CI) |
fhinkel
approved these changes
Oct 12, 2017
|
Got a weird flake on ubuntu1604_docker_alpine34-64, probably unrelated, but just to be sure: https://ci.nodejs.org/job/node-test-commit-linux/13185/ |
|
Landed in 7f55349...411695e, thanks! |
joyeecheung
pushed a commit
that referenced
this pull request
Oct 15, 2017
PR-URL: #16160 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
Move the logic for building the benchmark/misc/function_call to the top-level Makefile and use our local copy of node-gyp. PR-URL: nodejs/node#16160 Fixes: nodejs/node#16154 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
PR-URL: nodejs/node#16160 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
PR-URL: #16160 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
|
Should this be backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the logic for building the benchmark/misc/function_call to
the top-level Makefile and use our local copy of node-gyp.
Fixes: #16154 (cc @joyeecheung)