doc: Fix pbkdf2 example #16203
Closed
doc: Fix pbkdf2 example #16203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
crypto
|
/cc @nodejs/crypto |
tniessen
approved these changes
Oct 15, 2017
doc/api/crypto.md
Outdated
| @@ -1616,7 +1616,7 @@ Example: | |||
|
|
|||
| ```js | |||
| const crypto = require('crypto'); | |||
| crypto.pbkdf2('secret', 'salt', 100000, 512, 'sha512', (err, derivedKey) => { | |||
| crypto.pbkdf2('secret', 'salt', 100000, 64, 'sha512', (err, derivedKey) => { | |||
| if (err) throw err; | |||
| console.log(derivedKey.toString('hex')); // '3745e48...aa39b34' | |||
There was a problem hiding this comment.
You need to change this value as well (the first bytes should still be the same, but the last bytes will most likely be different).
doc/api/crypto.md
Outdated
| @@ -1668,7 +1668,7 @@ Example: | |||
|
|
|||
| ```js | |||
| const crypto = require('crypto'); | |||
| const key = crypto.pbkdf2Sync('secret', 'salt', 100000, 512, 'sha512'); | |||
| const key = crypto.pbkdf2Sync('secret', 'salt', 100000, 64, 'sha512'); | |||
| console.log(key.toString('hex')); // '3745e48...aa39b34' | |||
|
@tniessen I've updated the output. Shame on me for assuming it was outdated anyway. |
lpinca
approved these changes
Oct 15, 2017
jasnell
approved these changes
Oct 15, 2017
|
Landed in b5c74d8, thank you for your contribution! 🎉 |
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 18, 2017
PR-URL: nodejs/node#16203 Refs: nodejs/node#3415 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
512 bytes seems like a lot. See #3415