Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: http2 emitGoAway post shutdown pre destroy #16215

Closed
wants to merge 1 commit into from
Closed

test: http2 emitGoAway post shutdown pre destroy #16215

wants to merge 1 commit into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 15, 2017

This commit tests use case when emitGoAway is called when client is
shutting down but is not destroyed

node/lib/internal/http2/core.js

Lines 368 to 370 in 411695e

} else {
self.destroy();
}

Refs: #14985

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test, http2

@trivikr
test: http2 emitGoAway post shutdown pre destroy
9b74ec6 
This commit tests use case when emitGoAway is called when client is
shutting down but is not destroyed

Refs: nodejs#14985
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 15, 2017
@hiroppy hiroppy added the http2 Issues or PRs related to the http2 subsystem. label Oct 15, 2017
@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10744/

@jasnell
Copy link
Member

jasnell commented Oct 16, 2017

Failures in CI look unrelated.

mcollina
mcollina approved these changes Oct 17, 2017
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina self-assigned this Oct 17, 2017
@mcollina
Copy link
Member

Landed as d64e94b.

@mcollina mcollina closed this Oct 17, 2017
mcollina pushed a commit that referenced this pull request Oct 17, 2017
@trivikr @mcollina
test: http2 emitGoAway post shutdown pre destroy
d64e94b 
This commit tests use case when emitGoAway is called when client is
shutting down but is not destroyed.

Refs: #14985
PR-URL: #16215
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 18, 2017
@trivikr @addaleax
test: http2 emitGoAway post shutdown pre destroy
c288f99 
This commit tests use case when emitGoAway is called when client is
shutting down but is not destroyed.

Refs: nodejs/node#14985
PR-URL: nodejs/node#16215
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@trivikr trivikr deleted the test-http2-goaway-shutdown branch October 22, 2017 21:57
MylesBorins pushed a commit that referenced this pull request Oct 23, 2017
@trivikr @MylesBorins
test: http2 emitGoAway post shutdown pre destroy
327be77 
This commit tests use case when emitGoAway is called when client is
shutting down but is not destroyed.

Refs: #14985
PR-URL: #16215
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees

@mcollina mcollina

Labels
http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@trivikr @joyeecheung @jasnell @mcollina @cjihrig @MylesBorins @hiroppy @nodejs-github-bot