Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-process-kill-null #16236

Closed
wants to merge 1 commit into from
Closed

test: refactor test-process-kill-null #16236

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Oct 16, 2017

Use common.mustCall() instead of called variable.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@lpinca
test: refactor test-process-kill-null
385c7e0 
Use `common.mustCall()` instead of `called` variable.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 16, 2017
@lpinca
Copy link
Member Author

lpinca commented Oct 16, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10757/

@lpinca lpinca added the process Issues and PRs related to the process subsystem. label Oct 16, 2017
@jasnell
Copy link
Member

jasnell commented Oct 18, 2017

Failures in CI are unrelated.

jasnell pushed a commit that referenced this pull request Oct 18, 2017
@lpinca @jasnell
test: refactor test-process-kill-null
880415e 
Use `common.mustCall()` instead of `called` variable.

PR-URL: #16236
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@jasnell
Copy link
Member

jasnell commented Oct 18, 2017

Landed in 880415e

@jasnell jasnell closed this Oct 18, 2017
@lpinca lpinca deleted the refactor/test-process-kill-null branch October 18, 2017 15:41
targos pushed a commit that referenced this pull request Oct 18, 2017
@lpinca @targos
test: refactor test-process-kill-null
a601596 
Use `common.mustCall()` instead of `called` variable.

PR-URL: #16236
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@lpinca @addaleax
test: refactor test-process-kill-null
d106a9b 
Use `common.mustCall()` instead of `called` variable.

PR-URL: nodejs/node#16236
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@lpinca @MylesBorins
test: refactor test-process-kill-null
16f28cf 
Use `common.mustCall()` instead of `called` variable.

PR-URL: #16236
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@lpinca @MylesBorins
test: refactor test-process-kill-null
2d108c0 
Use `common.mustCall()` instead of `called` variable.

PR-URL: #16236
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@lpinca @MylesBorins
test: refactor test-process-kill-null
fa8315c 
Use `common.mustCall()` instead of `called` variable.

PR-URL: #16236
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@lpinca @addaleax
test: refactor test-process-kill-null
6c8b0d6 
Use `common.mustCall()` instead of `called` variable.

PR-URL: nodejs/node#16236
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@hiroppy hiroppy hiroppy approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@lpinca @jasnell @Fishrock123 @cjihrig @hiroppy @gireeshpunathil @BridgeAR @MylesBorins @nodejs-github-bot