doc: replace undocumented encoding aliases #16368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyeecheung
approved these changes
Oct 22, 2017
lpinca
approved these changes
Oct 22, 2017
bengl
approved these changes
Oct 22, 2017
vsemozhetbyt
added a commit
that referenced
this pull request
Oct 22, 2017
PR-URL: #16368 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
|
Landed in 93d1135 Thank you, @lingvoboard, for reporting this! |
|
This does not land cleanly on 8.x Could someone please backport |
2 tasks
|
Backport PR: #16421 |
2 tasks
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
PR-URL: nodejs/node#16368 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
Merged
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
PR-URL: nodejs/node#16368 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Currently, we support
utf-8as an alias forutf8, but it is not documented. We document this forutil.TextDecoderAPI, but it seems to be a different API. So maybe we can fix this fragments for consistency.