-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v8.x backport] util: expand test coverage for util.deprecate #16430
Conversation
Merge in other dependent changes as well. |
@akaila Can you rebase instead of merge? |
@trivikr I did a cherry pick as required in backporting. This is not a merge or rebase. |
FYI this is the test failure without the fix: python tools/test.py -J --mode=release parallel/test-internal-util-assertCrypto |
You shouldn't include anything that is not directly related to the specific PR you're backporting, even if tests are failing. That can be solved in a separate PR if necessary. That said, error changes are semver-major so that fix doesn't seem applicable to v8.x anyway. |
Ok I took out that commit. The only commit now is my test and its dependent code. |
@apapirovski the error change in 8ea3698 is in a test, not in core... so it wouldn't be semver major I too am very confused as to how that is passing on master edit: @apapirovski my bad, I'm seeing that the change to error codes is in the backport. |
@MylesBorins The issue I'm seeing is with a07981d811e2c22c57dbaf614a1caa94a34f30d4 being included here |
@akaila we cannot land a07981d in v8.x as it is a semver major change. As it would appear that the backport requires the error change I'm going to go ahead and close this My apologies for the miscommunication, thank you so much for taking the time to open this |
@MylesBorins I think this all got very confused. 😭 This should still be open, the issue is that it includes a07981d (incorrect) alongside 82134aa (correct) Maybe I'm missing something though... |
The real solution here should be to backport that test but change the error being tested for, since the error is different. `code` argument must be a string Without using the internal errors. |
I get it now. I will revert and modify the test and update the PR. Thanks |
hey all... common.expectsError is only for testing internal/error objects... as such I don't think this makes sense to continue with. It will be in 9.x, and the expanded coverage doesn't make sense for 8. I will avoid closing again but I advise that we close this |
|
@MylesBorins Is there downside to having an extra test for |
@targos gtk Sorry for being a party pooper, please safely ignore me |
Test for invalid argument types passed to code on util.deprecate. PR-URL: #16305 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Backported the test and corrected the error message and removed the error code. Verified it passes. |
8ec47e5
to
61413c2
Compare
b183192
to
fc8acc8
Compare
Test for invalid argument types passed to code on util.deprecate. PR-URL: #16305 Backport-PR-URL: #16430 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Test for invalid argument types passed to code on util.deprecate. PR-URL: #16305 Backport-PR-URL: #16430 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Backporting: #16305
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
util