-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update libuv to 1.5.0 #1646
Conversation
For bookkeeping purposes, this should close #1397. |
#862 should also be closable by this.. still looking through the list for others. |
#1512 also I think. Those four issues seem to be the ones this fixes. |
LGTM and the CI is happy. Landed in 04cc03b, thanks Saúl. |
I might need some help crafting a Notable Changes entry about this, I wasn't aware that we had so much resting on this, can someone in here take a stab at a summary of what this buys us? Also, great work @saghul, @bnoordhuis and other libuv folk! |
Maybe @indutny can comment on #1512. I kind of zoned out after the first few messages. |
Fixes: nodejs#1397 Fixes: nodejs#1512 Fixes: nodejs#1621 Fixes: nodejs#862 PR-URL: nodejs#1646 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
R=@bnoordhuis, @indutny
/cc @Fishrock123