Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove loader hooks from unsupported features #16465

Closed
wants to merge 1 commit into from
Closed

doc: remove loader hooks from unsupported features #16465

wants to merge 1 commit into from

Conversation

teppeis
Copy link
Contributor

@teppeis teppeis commented Oct 24, 2017

It's implemented in #15445.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 24, 2017
@hiroppy hiroppy added the esm Issues and PRs related to the ECMAScript Modules implementation. label Oct 24, 2017
@jasnell
Copy link
Member

jasnell commented Oct 25, 2017

this should not need to wait 48 hours to land

jasnell pushed a commit that referenced this pull request Oct 25, 2017
@teppeis @jasnell
doc: remove loader hooks from unsupported features
d2e44d5 
PR-URL: #16465
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell
Copy link
Member

jasnell commented Oct 25, 2017

Landed in d2e44d5

@jasnell jasnell closed this Oct 25, 2017
cjihrig pushed a commit that referenced this pull request Oct 25, 2017
@teppeis @cjihrig
doc: remove loader hooks from unsupported features
c8396b8 
PR-URL: #16465
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@cjihrig cjihrig mentioned this pull request Oct 25, 2017
Merged
@teppeis teppeis deleted the patch-1 branch October 26, 2017 00:08
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@teppeis @addaleax
doc: remove loader hooks from unsupported features
b1eaa82 
PR-URL: nodejs/node#16465
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@teppeis @addaleax
doc: remove loader hooks from unsupported features
5050111 
PR-URL: nodejs/node#16465
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@hiroppy hiroppy hiroppy approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@teppeis @jasnell @fhinkel @cjihrig @hiroppy @gireeshpunathil @MylesBorins @nodejs-github-bot