Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: move handle properties to prototype #16482

Closed
wants to merge 2 commits into from
Closed

src: move handle properties to prototype #16482

wants to merge 2 commits into from

Commits on Oct 25, 2017

  1. src: remove superfluous HandleScope 

    Accessors implicitly run inside a HandleScope, UDPWrap::GetFD() doesn't
need to create one explicitly.
    @bnoordhuis
    bnoordhuis committed Oct 25, 2017
    Configuration menu
    Copy the full SHA
    8e98120 View commit details
    Browse the repository at this point in the history

  2. src: move handle properties to prototype 

    Reduce the size of wrap objects by moving a couple of accessors from the
instance template to the prototype template.  They occupied one slot per
instance instead of one slot per class.

This commit fixes some instances of unwrapping twice since that code had
to be updated anyway to use `args.This()` instead of `args.Holder()`.
    @bnoordhuis
    bnoordhuis committed Oct 25, 2017
    Configuration menu
    Copy the full SHA
    1a7f752 View commit details
    Browse the repository at this point in the history