Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v8.8.1 proposal #16498

Merged
merged 15 commits into from
Oct 25, 2017
Merged

v8.8.1 proposal #16498

merged 15 commits into from
Oct 25, 2017

Commits on Oct 25, 2017

  1. doc: fix typo in zlib.md 

    PR-URL: #16480
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
    @lpinca @MylesBorins
    lpinca authored and MylesBorins committed Oct 25, 2017
    Configuration menu
    Copy the full SHA
    6fbef7f View commit details
    Browse the repository at this point in the history

  2. doc: add recommendations for first timers 

    PR-URL: #16350
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    @refack @cjihrig
    refack authored and cjihrig committed Oct 25, 2017
    Configuration menu
    Copy the full SHA
    99fdc1d View commit details
    Browse the repository at this point in the history

  3. doc: fix doc styles 

    CONTRIBUTING.md
  + L857: Unused definition
  + L861: Unused definition
  + L863: Unused definition

doc/api/assert.md
  + L719: Unused definition

doc/api/async_hooks.md
  + L460: Missing code-language flag

doc/api/child_process.md
  + L1362: Unused definition

doc/api/dns.md
  + L674: Unused definition

doc/api/esm.md
  + L178: Missing code-language flag

doc/api/http.md
  + L1868: Unused definition
  + L1887: Unused definition
  + L1888: Unused definition
  + L1889: Unused definition
  + L1916: Unused definition
  + L1917: Unused definition

doc/api/https.md
  + L260: Unused definition

doc/api/os.md
  + L1226: Unused definition

doc/api/process.md
  + L1888: Unused definition

doc/api/stream.md
  + L2227: Definitions with the same identifier

doc/guides/writing-and-running-benchmarks.md
  + L1: Missing newline character at end of file

Refs: #12756
PR-URL: #16385
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @watilde @cjihrig
    watilde authored and cjihrig committed Oct 25, 2017
    Configuration menu
    Copy the full SHA
    16eb7d3 View commit details
    Browse the repository at this point in the history

  4. doc: fix missing newline character 

    PR-URL: #16447
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    @watilde @cjihrig
    watilde authored and cjihrig committed Oct 25, 2017
    Configuration menu
    Copy the full SHA
    7facaa5 View commit details
    Browse the repository at this point in the history

  5. doc: fix typo in changelog for 8.8.0 

    PR-URL: #16462
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    @cjihrig
    Alec Perkins authored and cjihrig committed Oct 25, 2017
    Configuration menu
    Copy the full SHA
    9ffc329 View commit details
    Browse the repository at this point in the history

  6. doc: fix wrong URL 

    PR-URL: #16470
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    @maclover7 @cjihrig
    maclover7 authored and cjihrig committed Oct 25, 2017
    Configuration menu
    Copy the full SHA
    2b0bb57 View commit details
    Browse the repository at this point in the history

  7. doc: remove loader hooks from unsupported features 

    PR-URL: #16465
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @teppeis @cjihrig
    teppeis authored and cjihrig committed Oct 25, 2017
    Configuration menu
    Copy the full SHA
    c8396b8 View commit details
    Browse the repository at this point in the history

  8. doc: fix spelling in v8.8.0 changelog 

    I hear that varible has an a in it.

PR-URL: #16477
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    @MylesBorins @cjihrig
    MylesBorins authored and cjihrig committed Oct 25, 2017
    Configuration menu
    Copy the full SHA
    db8c92f View commit details
    Browse the repository at this point in the history

  9. test: add missing assertion 

    This commit adds an assertion to an existing try...catch
statement. Unfortunately, assert.throws() cannot be used
because the operation succeeds on some platforms, throws
EINVAL on some platforms, and throws ENOPROTOOPT on
others.

PR-URL: #15519
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @cjihrig
    cjihrig committed Oct 25, 2017
    Configuration menu
    Copy the full SHA
    2a53165 View commit details
    Browse the repository at this point in the history

  10. test: allow for different nsswitch.conf settings 

    The motivation for this commit is that these two test fail on systems
that have different Name Service Switch configuration settings. A
concrete example of this is when using Red Hat Enterprise Linux (RHEL)
7.

If Name Service Switch is available on the operating system then it
might be configured differently (/etc/nsswitch.conf).
If the system is configured with no dns the error code will be
AI_AGAIN, but if there are more services after the dns entry, for
example some linux distributions skip a myhostname service by default
which would still produce the ENOTFOUND error.

This commit suggests checking for either ENOTFOUND or EAI_AGAIN to
accommodate systems like the ones described above. The references below
indicate that others have run, or are running, into this aswell.

Refs: #12075
Refs: nodejs/help#687
Refs: #15825
PR-URL: #16378
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @danbev @cjihrig
    danbev authored and cjihrig committed Oct 25, 2017
    Configuration menu
    Copy the full SHA
    ef0551f View commit details
    Browse the repository at this point in the history

  11. test: call toLowerCase on the resolved module 

    The commit updates test-require-resolve.js to call toLowerCase on the
resolved module instead of the path. Currently this test will fail if
the path to where node exists contains uppercase letters. For example:

```
$ out/Release/node
test/parallel/test-require-resolve.js
/root/rpmbuild/BUILD/node-v8.8.0/test/parallel
module.js:515
    throw err;
    ^

Error: Cannot find module
'/root/rpmbuild/build/node-v8.8.0/test/fixtures/nested-index/one'
    at Function.Module._resolveFilename (module.js:513:15)
    at Function.resolve (internal/module.js:18:19)
    at Object.<anonymous>
(/root/rpmbuild/BUILD/node-v8.8.0/test/parallel/test-require-resolve.js:37:11)
    at Module._compile (module.js:612:30)
    at Object.Module._extensions..js (module.js:623:10)
    at Module.load (module.js:531:32)
    at tryModuleLoad (module.js:494:12)
    at Function.Module._load (module.js:486:3)
    at Function.Module.runMain (module.js:653:10)
    at startup (bootstrap_node.js:187:16)
```

PR-URL: #16486
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>>
Reviewed-By: Anna Henningsen <anna@addaleax.net>>
Reviewed-By: James M Snell <jasnell@gmail.com>>
    @danbev @cjihrig
    danbev authored and cjihrig committed Oct 25, 2017
    Configuration menu
    Copy the full SHA
    9f87d6a View commit details
    Browse the repository at this point in the history

  12. test: make test-v8-serdes work without stdin 

    If `stdin` was closed or referred to a file, this didn't work,
because it was accessed via file descriptor.

Instead, use another generic native object.

cherry-picked from ayojs/ayo#63

Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @addaleax @cjihrig
    addaleax authored and cjihrig committed Oct 25, 2017
    1 Configuration menu
    Copy the full SHA
    d66c927 View commit details
    Browse the repository at this point in the history

  13. net: fix timeout with null handle 

    This commit handles the case where _onTimeout is called with a
null handle.

Refs: #15791
Fixes: #16484
PR-URL: #16489
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
    @apapirovski @cjihrig
    apapirovski authored and cjihrig committed Oct 25, 2017
    Configuration menu
    Copy the full SHA
    bf02780 View commit details
    Browse the repository at this point in the history

  14. 2017-10-25, Version 8.8.1 (Current) 

    Notable changes:

* net:
  - Fix timeout with null handle issue. This is a regression in
    Node 8.8.0. #16489
    @cjihrig
    cjihrig committed Oct 25, 2017
    Configuration menu
    Copy the full SHA
    dc6bbb4 View commit details
    Browse the repository at this point in the history

  15. Working on v8.8.2 

    PR-URL: #16498
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
    @cjihrig
    cjihrig committed Oct 25, 2017
    Configuration menu
    Copy the full SHA
    4359a93 View commit details
    Browse the repository at this point in the history