module: add API for identifying core modules #16555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is userland code currently making unsafe use of
`process.binding('natives')` to identify core modules.
This points to an obvious need for a supported public
API. Let's provide one to discourage userland use of
private APIs
nodejs-github-bot
added
the
module
jasnell
added
the
semver-minor
|
Perhaps this should be done as suggestions in #16386? |
|
I'd forgotten about that PR! I'll close this one and provide input on that one. Thanks :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is userland code currently making unsafe use of
process.binding('natives')to identify core modules.This points to an obvious need for a supported public
API. Let's provide one to discourage userland use of
private APIs
Userland example: https://github.com/facebook/jest/pull/4740/files#diff-240429220dd8540b70d06b165fc63ad3R5
/cc @bmeck @addaleax @bengl
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
modules